fix return types in asset erc20 and refactor asseterc20precompileset #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss AssetId in PrecompileSet
girazoki
changed the title
girazoki
added
the
B7-runtimenoteworthy
…rn-types-in-asset-erc20-and-refactor-asseterc20precompileset
nanocryk
reviewed
Nov 15, 2021
girazoki
added
the
C7-high
librelois
approved these changes
Nov 16, 2021
| @@ -194,7 +194,7 @@ fn export_current_state() { | |||
|
|
|||
| // Let it produce some blocks. | |||
| // This fails if is not a minimum of 25 | |||
| thread::sleep(Duration::from_secs(25)); | |||
| thread::sleep(Duration::from_secs(35)); | |||
There was a problem hiding this comment.
I guess because of the JIT compilation issue. but the CI was complaining:(
There was a problem hiding this comment.
This can [hopefully] be reverted once 993 is merged.
girazoki
deleted the
girazoki-fix-return-types-in-asset-erc20-and-refactor-asseterc20precompileset
branch
girazoki
added a commit
that referenced
this pull request
Nov 17, 2021
…990) * Fix return type matching the open zeppeling ERC20 and the way to access AssetId in PrecompileSet * Start typescrypt testing this * Fix typescript integration tests * Check if caller is same as from * add delgeate calls to contract instance * add more cases considering delegate and normal calls * Add contract compiled * Increment node wake up time yet again * Increment the proper timeout * Add PR suggestions
girazoki
added a commit
that referenced
this pull request
Nov 17, 2021
* fix return types in asset erc20 and refactor asseterc20precompileset (#990) * Fix return type matching the open zeppeling ERC20 and the way to access AssetId in PrecompileSet * Start typescrypt testing this * Fix typescript integration tests * Check if caller is same as from * add delgeate calls to contract instance * add more cases considering delegate and normal calls * Add contract compiled * Increment node wake up time yet again * Increment the proper timeout * Add PR suggestions * Bump specs to 902 in moonbase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It solves some issues found in assets-erc20-precompiles when being called form a smart contract. IN particular:
DelegateCalls where not working, since we were fetching the assetId from execution_address, but delegateCalls take the calling smart contract as execution_address. I made a refactor to avoid this situation, and I think the code looks cleaner now.
Calls from a SC to transfer, approve, TransferFrom were not working, as we were not returning a boolean as the execution result. This is required by the ERC-20 standard, so I added this fixing the corresponding tests.
Added a ton of typescript tests regarding delegateCalls and smart contract calls cases. I think I have covered most of the stuff now
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?