Assets erc20 call delegate call hotfix runtime 902 #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…990) * Fix return type matching the open zeppeling ERC20 and the way to access AssetId in PrecompileSet * Start typescrypt testing this * Fix typescript integration tests * Check if caller is same as from * add delgeate calls to contract instance * add more cases considering delegate and normal calls * Add contract compiled * Increment node wake up time yet again * Increment the proper timeout * Add PR suggestions
librelois
approved these changes
Nov 17, 2021
girazoki
added
the
B7-runtimenoteworthy
nanocryk
approved these changes
Nov 17, 2021
girazoki
deleted the
assets-erc20-call-delegate-call-hotfix-runtime-902
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the hotfix for asset erc20 approvals to runtime 902
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?