Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace findhit-utils with lodash at runtime (fixes #36) #37

Merged
merged 1 commit into from
May 9, 2022
Merged

Replace findhit-utils with lodash at runtime (fixes #36) #37

merged 1 commit into from
May 9, 2022

Conversation

TjlHope
Copy link

@TjlHope TjlHope commented Apr 25, 2022

This lib is BSD, but had a runtime dependency on the GPL findhit-utils,
meaning any derivitive works need to be GPL.

findhit-util is still used as a dev dependency for testing the options
behaviour.

package.json "files" array has been added to not include the test code
in the resulting package so there's no GPL dependant code in the
resulting library.

This lib is BSD, but had a runtime dependency on the GPL findhit-utils,
meaning any derivitive works need to be GPL.

findhit-util is still used as a dev dependency for testing the options
behaviour.

package.json "files" array has been added to not include the test code
in the resulting package so there's no GPL dependant code in the
resulting library.
@TjlHope
Copy link
Author

TjlHope commented May 9, 2022

Hi @cusspvz , any chance you'd be able to take a look at this PR?
Thanks, Tom

@cusspvz cusspvz merged commit d96ffd1 into mosano-eu:master May 9, 2022
@cusspvz
Copy link
Member

cusspvz commented May 9, 2022

Thanks for your contribute! Landed these changes and published a new patch release, as we haven't added new functionalities. 0.3.13 should not depend on the findhit-util anymore. 🥳

@TjlHope
Copy link
Author

TjlHope commented May 9, 2022

Brilliant, thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants