Fix clang version detection, update freebsd ci #1874
Conversation
sylvestre
force-pushed
the
fix-clang-and-freebsd-ci
branch
from
319e4a4
to
97dc66a
Compare
| @@ -38,9 +38,9 @@ use crate::errors::*; | |||
| /// A struct on which to implement `CCompilerImpl`. | |||
| #[derive(Clone, Debug)] | |||
| pub struct Clang { | |||
| /// true iff this is clang++. | |||
| /// true if this is clang++. | |||
There was a problem hiding this comment.
why this change?
iff means If and only if
There was a problem hiding this comment.
Just seems odd, as "if" is totally sufficient in this case (otherwise we would write iff true {, wouldn’t we?). And yes, I wasn’t aware ;)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
=======================================
Coverage 29.80% 29.80%
=======================================
Files 49 49
Lines 17516 17516
Branches 8423 8425 +2
=======================================
Hits 5220 5220
- Misses 7212 7213 +1
+ Partials 5084 5083 -1
☔ View full report in Codecov by Sentry. |
|
could you please create a PR for freebsd and one for clang detection. (i already merged a different pr about the action update) |
Hm, they were kind of related (technically it could also be three separate ones of course - fix bsd unit tests, fix clang detecting, update FreeBSD), but they would need to be applied in order for tests to succeed. I see what I can do (later). |
To me more precise, updating FreeBSD to 13.2 brought in clang >=14 which in turn exposed the bug in the clang unit test and once that was fixed, it exposed a bug in clang version parsing on Ubuntu (the bug in the clang unit test masked the bug in clang version parsing when there was no additional information, like a url, after the version number). Anyway :) |
Also updated checkout action, since v3 started to fail today.