Fix detection of clang version and v14+ unit tests #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler version (__VERSION__) is always enclosed in quotes. This only fixes version detection for clang to keep the scope small. Stripping quotes could also be done globally in compiler.rs.
|
would it be possible to have a test for this? |
Closed
It's two things - the unit test code itself was broken. Once it was fixes (test/system.rs), the problematic behavior was exposed. We could have a basic unit test of course (not really hard to do). Not sure how much it buys us, but also won't hurt... |
grembo
force-pushed
the
fix-clang-version-check-and-tests
branch
from
43d8e94
to
5ee7c72
Compare
grembo
force-pushed
the
fix-clang-version-check-and-tests
branch
from
5ee7c72
to
8cade2e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 29.80% 29.87% +0.07%
==========================================
Files 49 49
Lines 17516 17528 +12
Branches 8423 8430 +7
==========================================
+ Hits 5220 5237 +17
+ Misses 7212 7211 -1
+ Partials 5084 5080 -4
☔ View full report in Codecov by Sentry. |
grembo
force-pushed
the
fix-clang-version-check-and-tests
branch
from
c2fb5d2
to
d456957
Compare
sylvestre
reviewed
Sep 5, 2023
| @@ -252,6 +252,38 @@ mod test { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler version (
__VERSION__) is always enclosed in quotes.This only fixes version detection for clang to keep the scope small.
Stripping quotes could also be done globally in compiler.rs.