Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete from redis if keys are available #1095

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Dec 14, 2021

closes #1090

@vercel
Copy link

vercel bot commented Dec 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/envelop/HFtncSV1biUWrADVawBofZ12EiPk
✅ Preview: https://envelop-git-no-purge-on-invalid-theguild.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2021

🦋 Changeset detected

Latest commit: 4c5e89d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/response-cache-redis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 14, 2021

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/response-cache-redis@0.1.4-alpha-00464e8.0

@theguild-bot
Copy link
Collaborator

theguild-bot commented Dec 14, 2021

✅ Benchmark Results

     data_received......................................: 0 B     0 B/s
     data_sent..........................................: 0 B     0 B/s
     http_req_blocked...................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_connecting................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_duration..................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     ✓ { mode:envelop-cache-jit }.......................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     ✓ { mode:envelop-just-cache }......................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     ✓ { mode:graphql-js }..............................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     ✓ { mode:prom-tracing }............................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_failed....................................: 100.00% ✓ 211819      ✗ 0   
     http_req_receiving.................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_sending...................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_tls_handshaking...........................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_req_waiting...................................: avg=0s     min=0s      med=0s     max=0s      p(90)=0s     p(95)=0s    
     http_reqs..........................................: 211819  4236.015609/s
     iteration_duration.................................: avg=2.25ms min=100.9µs med=1.53ms max=46.48ms p(90)=4.85ms p(95)=6.61ms
     iterations.........................................: 211819  4236.015609/s
     vus................................................: 1       min=1         max=20
     vus_max............................................: 40      min=40        max=40

@dotansimha dotansimha merged commit 7f72996 into main Dec 14, 2021
@dotansimha dotansimha deleted the no-purge-on-invalid branch December 14, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis response cache will halt the server if resolver return nullable type
4 participants