Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete from redis if keys are available #1095

Merged
merged 3 commits into from
Dec 14, 2021
Merged

fix: delete from redis if keys are available #1095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cb6d7a
fix: only delete from store if there are keys to delete
saihaj Dec 14, 2021
abad43a
chore: add changeset
saihaj Dec 14, 2021
4c5e89d
refactor: flatten keys first then delete if needed
saihaj Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: only delete from store if there are keys to delete
  • Loading branch information
@saihaj
saihaj committed Dec 14, 2021
commit 2cb6d7a0d84f416912b222711ebceb20eaa9ed6c
4 changes: 3 additions & 1 deletion packages/plugins/response-cache-redis/src/redis-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ export const createRedisCache = (params: RedisCacheParameter): Cache => {
invalidationKeys.push(await buildEntityInvalidationsKeys(id != null ? buildRedisEntityId(typename, id) : typename));
}

await store.del(invalidationKeys.flat());
if (invalidationKeys.length > 0) {
await store.del(invalidationKeys.flat());
}
},
};
};
Expand Down