Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement symbol naming convention for SC #113

Closed
3 tasks done
jphickey opened this issue Oct 9, 2023 · 0 comments · Fixed by #125
Closed
3 tasks done

Implement symbol naming convention for SC #113

jphickey opened this issue Oct 9, 2023 · 0 comments · Fixed by #125
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

jphickey commented Oct 9, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
SC is not consistent in the way its symbols and related definitions are named.

Examples:
RTS_ID_AUTO_POWER_ON -- should have SC_ namespace prefix.
Enums like SC_LOADED and SC_IDLE etc should be defined as an enum with a proper qualifier on every label.

Describe the solution you'd like
Identifiers should follow the naming convention laid out in https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 12, 2023
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
55fcadc 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
1a2cac8 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
@jphickey jphickey mentioned this issue Oct 24, 2023
Merged
2 tasks
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
628434e 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
1f40c79 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
9a37991 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#113, define proper enumerations for SC constants
6303d33 
Create enumerations according to the style documented in CFE.  Existing
symbols are put inside a backward compatibility switch, such that
existing table and message definitions should still work.
dzbaker added a commit that referenced this issue Oct 26, 2023
@dzbaker
Merge pull request #125 from jphickey/fix-113-123-symbols
ab3a9a0 
Fix #113, Fix #123, Symbol naming convention and message conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #113, Fix #123, Symbol naming convention and message conversions jphickey/SC
1 participant
@jphickey