Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CFE_MSG_PTR conversion macro #123

Closed
3 tasks done
jphickey opened this issue Oct 24, 2023 · 0 comments · Fixed by #125
Closed
3 tasks done

Use CFE_MSG_PTR conversion macro #123

jphickey opened this issue Oct 24, 2023 · 0 comments · Fixed by #125
Assignees
@jphickey
Labels
enhancement

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
When passing a pointer to a message, apps should use the CFE_MSG_PTR conversion macro provided via the CFE_MSG module, rather than taking the address of a sub-structure.

Describe the solution you'd like
Change the calls that access the CFE_MSG_Message_t sub-object to use the macro instead.

Additional context
This is because the name of the sub-object is defined by the CFE_MSG module, it may be different. The macro is intended to safely convert from a container struct into a message pointer, based on the way the MSG module defines it.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 24, 2023
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
c0996ad 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
@jphickey jphickey mentioned this issue Oct 24, 2023
Closed
2 tasks
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
92da8ef 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
cb48699 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
@jphickey jphickey mentioned this issue Oct 24, 2023
Merged
2 tasks
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
e97dcb5 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
bd37cab 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
9ac3165 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
jphickey added a commit to jphickey/SC that referenced this issue Oct 24, 2023
@jphickey
Fix nasa#123, use CFE_MSG_PTR conversion macro
957b10b 
Rather than taking the address of a sub-member, use the macro provided
from the CFE_MSG module to convert from a local container to a
CFE_MSG_Messge_t pointer.
dzbaker added a commit that referenced this issue Oct 26, 2023
@dzbaker
Merge pull request #125 from jphickey/fix-113-123-symbols
ab3a9a0 
Fix #113, Fix #123, Symbol naming convention and message conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@jphickey