Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent type for EventID #1435

Closed
skliper opened this issue Apr 28, 2021 · 0 comments · Fixed by #1572
Closed

Use consistent type for EventID #1435

skliper opened this issue Apr 28, 2021 · 0 comments · Fixed by #1572
Labels
CFS-41 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 28, 2021

Is your feature request related to a problem? Please describe.
EventID is defined as int16 and uint16, examples:

cFE/modules/evs/fsw/src/cfe_evs_utils.c

Line 311 in 73c338d

EVS_BinFilter_t *EVS_FindEventID(int16 EventID, EVS_BinFilter_t *FilterArray)

cFE/modules/evs/fsw/src/cfe_evs_utils.c

Line 379 in 73c338d

void EVS_GenerateEventTelemetry(EVS_AppData_t *AppDataPtr, uint16 EventID, uint16 EventType,

Describe the solution you'd like
Use a consistent definition.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 28, 2021
skliper added a commit to skliper/cFE that referenced this issue May 24, 2021
@skliper
Fix nasa#1435, Consistent use of uint16 for EventID
ee935e1
skliper added a commit to skliper/cFE that referenced this issue May 24, 2021
@skliper
Fix nasa#1435, Consistent use of uint16 for EventID
1fec56e
skliper added a commit to skliper/cFE that referenced this issue May 25, 2021
@skliper
Fix nasa#1435, Consistent use of uint16 for EventID
d685d0e
@skliper skliper mentioned this issue May 25, 2021
Merged
astrogeco added a commit that referenced this issue Jun 2, 2021
@astrogeco
Merge pull request #1572 from skliper/fix1435-eventid_type
00d1a39 
Fix #1435, Consistent use of uint16 for EventID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-41 enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1435, Consistent use of uint16 for EventID skliper/cFE
1 participant
@skliper