Skip to content

Commit

Permalink
Fix nasa#1435, Consistent use of uint16 for EventID
Browse files Browse the repository at this point in the history
  • Loading branch information
skliper committed May 24, 2021
1 parent 8443a46 commit ee935e1
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion modules/core_api/fsw/inc/cfe_evs.h
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ CFE_Status_t CFE_EVS_SendTimedEvent(CFE_TIME_SysTime_t Time, uint16 EventID, uin
** \sa #CFE_EVS_ResetAllFilters
**
**/
CFE_Status_t CFE_EVS_ResetFilter(int16 EventID);
CFE_Status_t CFE_EVS_ResetFilter(uint16 EventID);

/**
** \brief Resets all of the calling application's event filters.
Expand Down
2 changes: 1 addition & 1 deletion modules/core_api/ut-stubs/src/cfe_evs_stubs.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ CFE_Status_t CFE_EVS_ResetAllFilters(void)
* Generated stub function for CFE_EVS_ResetFilter()
* ----------------------------------------------------
*/
CFE_Status_t CFE_EVS_ResetFilter(int16 EventID)
CFE_Status_t CFE_EVS_ResetFilter(uint16 EventID)
{
UT_GenStub_SetupReturnBuffer(CFE_EVS_ResetFilter, CFE_Status_t);

Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/src/cfe_evs.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ int32 CFE_EVS_SendTimedEvent(CFE_TIME_SysTime_t Time, uint16 EventID, uint16 Eve
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_EVS_ResetFilter(int16 EventID)
int32 CFE_EVS_ResetFilter(uint16 EventID)
{
int32 Status;
EVS_BinFilter_t *FilterPtr = NULL;
Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/src/cfe_evs_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ bool EVS_IsFiltered(EVS_AppData_t *AppDataPtr, uint16 EventID, uint16 EventType)
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
EVS_BinFilter_t *EVS_FindEventID(int16 EventID, EVS_BinFilter_t *FilterArray)
EVS_BinFilter_t *EVS_FindEventID(uint16 EventID, EVS_BinFilter_t *FilterArray)
{
uint32 i;

Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/src/cfe_evs_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ bool EVS_IsFiltered(EVS_AppData_t *AppDataPtr, uint16 EventID, uint16 EventType)
* This routine searches and returns an index to the given Event ID with the
* given application filter array.
*/
EVS_BinFilter_t *EVS_FindEventID(int16 EventID, EVS_BinFilter_t *FilterArray);
EVS_BinFilter_t *EVS_FindEventID(uint16 EventID, EVS_BinFilter_t *FilterArray);

/*---------------------------------------------------------------------------------------*/
/**
Expand Down
2 changes: 1 addition & 1 deletion modules/evs/ut-coverage/evs_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ void Test_Format(void)
{
int i;
char long_msg[CFE_MISSION_EVS_MAX_MESSAGE_LENGTH + 2];
int16 EventID[2];
uint16 EventID[2];

CFE_TIME_SysTime_t time = {0, 0};
CFE_EVS_SetEventFormatModeCmd_t modecmd;
Expand Down

0 comments on commit ee935e1

Please sign in to comment.