Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #499, store all arguments in generic-linux BSP #500

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

jphickey
Copy link
Contributor

Describe the contribution

Keep the entire argc/argv from the shell. Do not prune the command name as getopt expects this to be there.

Fixes #499

Testing performed
Execute unit tests, confirm all passing.
Execute new PSP tests, confirm command line options are being recognized.

Expected behavior changes
Command line options in Linux are recognized, no longer ignored/dropped.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Keep the entire argc/argv from the shell.  Do not prune the command
name as getopt expects this to be there.
@skliper
Copy link
Contributor

skliper commented Jun 12, 2020

Ping @SweeWarman

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 16, 2020
@astrogeco
Copy link
Contributor

CCB 2020-06-17: APPROVED

@astrogeco astrogeco added CCB-20200617 and removed CCB-20200627 CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 17, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate June 22, 2020 19:41
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Jun 22, 2020
@astrogeco astrogeco merged commit 4878b90 into nasa:integration-candidate Jun 23, 2020
@skliper skliper added this to the 5.1.0 milestone Aug 21, 2020
@jphickey jphickey deleted the fix-499-linux-args branch December 3, 2020 17:26
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux BSP shouldn't trim first argument
3 participants