Integration candidate: 2020-06-17 #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the entire argc/argv from the shell. Do not prune the command name as getopt expects this to be there.
Add a position independent code (PIC) variant of the ut_assert library, which can be dynamically loaded into other applications rather than running as a standalone OSAL application. This enables loading UT assert as a CFE library. This required moving some symbols/functions around. Mainly, the PIC library does _not_ contain the "utbsp.c" file which has the bindings to the OSAL BSP when running as a standalone app, but everything else should be the same.
Resolve inconsistency in how the stack size is treated across different OS implemntations. POSIX would enforce a minimum, where RTEMS would not. With this change the user requested size is passed through to the underlying OS exactly as is, no enforced minimum. An additional sanity check is added at the shared layer to ensure that the stack size is never passed as 0.
Add requisite cast to printf. Also use sizeof() rather than hardcoded size of 12.
The pthread API defines the timeout parameter for the pthread_mutex_timedlock call as an absolute value based on CLOCK_REALTIME. This introduces a wrapper function to calculate the absolute timeout for this.
Fix #499, store all arguments in generic-linux BSP
Fix #501, add PIC library for ut assert
Fix #520, Update license and README for Apache 2.0, also updated quickstart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #499
Fix #501
Fix #505
Fix #506
Fix #520
Fix #351
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/106/checks
Expected behavior changes
PR #500 - Command line options in Linux are recognized, no longer ignored/dropped.
PR #504 - No impact to current unit testing which runs UT assert as a standalone app. Add a position independent code (PIC) variant of the ut_assert library, which can be dynamically loaded into other applications rather than running as a standalone OSAL application. This enables loading
UT assert as a CFE library.
PR #507 - Unit tests pass on RTEMS.
PR #508 - Resolve inconsistency in how the stack size is treated across different OS implemntations. With this change the user-requested size is passed through to the underlying OS without an enforced minimum. An additional sanity check is added at the shared layer to ensure that the stack size is never passed as 0.
PR #524 - Update Licenses for Apache 2.0
System(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#106
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Jacob Hageman, NASA-GSFC