Fix #501, add PIC library for ut assert #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a position independent code (PIC) variant of the ut_assert library, which can be dynamically loaded into other applications rather than running as a standalone OSAL application. This enables loading UT assert as a CFE library. This required moving some symbols/functions around. Mainly, the PIC library does _not_ contain the "utbsp.c" file which has the bindings to the OSAL BSP when running as a standalone app, but everything else should be the same.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jun 16, 2020
|
CCB 2020-06-17: APPROVED |
astrogeco
removed
the
CCB:Ready
astrogeco
added
IC-20200617
CCB:Approved
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#487, CFE_TIME_print format fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add a position independent code (PIC) variant of the ut_assert library, which can be dynamically loaded into other applications rather than running as a standalone OSAL application. This enables loading UT assert as a CFE library.
This required moving some symbols/functions around. Mainly, the PIC library does not contain the
utbsp.cfile which has the bindings to the OSAL BSP when running as a standalone app, but everything else should be the same.Fixes #501
Testing performed
Build and execute all unit tests.
Also test linking new PIC library into a CFE loadable app and running tests.
Expected behavior changes
No impact to current unit testing which runs UT assert as a standalone app.
System(s) tested on
Ubuntu 20.04
Additional context
Some functions were moved to support the alternative linking structure but no API/functionality changes. The moved functions include the buffer length extension that were originally part of PR #492.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.