Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Rebuild state if matched properly for index.db but we find additional blocks #5907

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

derekcollison
Copy link
Member

When determining to rebuild state, when we match the last record in the last block indicated by index.db, we still need to check for additional blocks.

Signed-off-by: Derek Collison derek@nats.io

… last block by index.db, we still need to check for additional blocks.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/filestore_test.go Outdated Show resolved Hide resolved
server/filestore_test.go Show resolved Hide resolved
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit 04d7097 into main Sep 20, 2024
1 check passed
@derekcollison derekcollison deleted the fs-restore-exact branch September 20, 2024 14:13
neilalexander pushed a commit that referenced this pull request Sep 20, 2024
…ditional blocks (#5907)

When determining to rebuild state, when we match the last record in the
last block indicated by index.db, we still need to check for additional
blocks.

Signed-off-by: Derek Collison <derek@nats.io>

---------

Signed-off-by: Derek Collison <derek@nats.io>
neilalexander pushed a commit that referenced this pull request Sep 20, 2024
…ditional blocks (#5907)

When determining to rebuild state, when we match the last record in the
last block indicated by index.db, we still need to check for additional
blocks.

Signed-off-by: Derek Collison <derek@nats.io>

---------

Signed-off-by: Derek Collison <derek@nats.io>
neilalexander pushed a commit that referenced this pull request Sep 20, 2024
…ditional blocks (#5907)

When determining to rebuild state, when we match the last record in the
last block indicated by index.db, we still need to check for additional
blocks.

Signed-off-by: Derek Collison <derek@nats.io>

---------

Signed-off-by: Derek Collison <derek@nats.io>
neilalexander added a commit that referenced this pull request Sep 20, 2024
Includes the following:

- #5901
- #5904
- #5900
- #5906
- #5908
- #5907

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants