Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Fix for new static check failure. #5908

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[FIXED] Fix for new static check failure. #5908

merged 1 commit into from
Sep 20, 2024

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner September 20, 2024 02:55
@derekcollison
Fix for new static check failure.
8cf2c59 
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
neilalexander approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 7610de3 into main Sep 20, 2024
5 checks passed
@derekcollison derekcollison deleted the static-check-fix branch September 20, 2024 14:08
@neilalexander neilalexander mentioned this pull request Sep 20, 2024
Merged
neilalexander added a commit that referenced this pull request Sep 20, 2024
@neilalexander
Cherry-picks for 2.10.21-RC.2 (#5911)
fd3a2e6 
Includes the following:

- #5901
- #5904
- #5900
- #5906
- #5908
- #5907

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekcollison @neilalexander