Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move] Part-3 Classes into Different Library - Neo.Extensions #3400

Merged
merged 17 commits into from
Jul 30, 2024
Merged

[Move] Part-3 Classes into Different Library - Neo.Extensions #3400

merged 17 commits into from
Jul 30, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jul 5, 2024 •
edited
Loading

Description

Reorganized and move classes from neo library to neo.io and neo.extensions library.

Fixed problems and warnings that occurred. Along with naming violations.

Change Log

  • Removed methods BitLen unused.
  • Move method ToHexString to ./src/Plugins/Neo.Extensions/ByteExtensions.cs
  • Added Using Neo.Extensions where needed
  • Replaced method Concat with C# collections concat.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 changed the title [Move] Part-2 Classes into Different Library - Neo.Extensions [Move] Part-3 Classes into Different Library - Neo.Extensions Jul 5, 2024
@cschuchardt88 cschuchardt88 added blocked This issue can't be worked at the moment waiting for review labels Jul 5, 2024
@Jim8y Jim8y added blocker Issues that are blocking other issues. Check issues details to see what it is blocking. waiting for review and removed waiting for review blocked This issue can't be worked at the moment labels Jul 16, 2024
Jim8y
Jim8y previously approved these changes Jul 23, 2024
View reviewed changes
shargon
shargon previously approved these changes Jul 29, 2024
View reviewed changes
@Jim8y Jim8y added ready to merge and removed blocker Issues that are blocking other issues. Check issues details to see what it is blocking. waiting for review labels Jul 29, 2024
@NGDAdmin NGDAdmin merged commit 1c3fe45 into neo-project:master Jul 30, 2024
7 checks passed
@shargon shargon deleted the rebuild/the-split-3 branch July 30, 2024 06:59
Jim8y added a commit to Jim8y/neo that referenced this pull request Aug 1, 2024
@Jim8y
Merge branch 'master' into fix-compound-reference
38c3c16 
* master:
  [Neo Core Add] add char support (neo-project#3441)
  [rpc] Extend `getversion` RPC response with additional protocol settings (neo-project#3443)
  update benchmark system (neo-project#3442)
  [`Optimization`] Parsing Smart Contract Script Analysis (neo-project#3420)
  `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (neo-project#3400)

# Conflicts:
#	benchmarks/Neo.Benchmarks/Benchmarks.POC.cs
#	benchmarks/Neo.VM.Benchmarks/Benchmarks.POC.cs
#	benchmarks/Neo.VM.Benchmarks/Program.cs
Jim8y added a commit to Jim8y/neo that referenced this pull request Aug 2, 2024
@Jim8y
Merge branch 'standardize-exception' of github.com:Jim8y/neo into sta…
449adc0 
…ndardize-exception

* 'standardize-exception' of github.com:Jim8y/neo:
  Clean using
  [Neo Core Add] add char support (neo-project#3441)
  [rpc] Extend `getversion` RPC response with additional protocol settings (neo-project#3443)
  update benchmark system (neo-project#3442)
  [`Optimization`] Parsing Smart Contract Script Analysis (neo-project#3420)
  `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (neo-project#3400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cschuchardt88 @shargon @Jim8y @NGDAdmin