Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] Extend getversion RPC response with additional protocol settings #3443

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[rpc] Extend getversion RPC response with additional protocol settings #3443

merged 3 commits into from
Jul 30, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 29, 2024

Description

Fix #3401

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • UT_RpcServer.TestGetVersion

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88
cschuchardt88 previously approved these changes Jul 29, 2024
View reviewed changes
roman-khimov
roman-khimov reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to extend the RPC client as well?

@Jim8y
Copy link
Contributor

Jim8y commented Jul 30, 2024

@chenzhitong please update the document accordingly.

Jim8y
Jim8y previously approved these changes Jul 30, 2024
View reviewed changes
NGDAdmin
NGDAdmin requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@NGDAdmin NGDAdmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shargon Please update RpcClient as well.

@shargon shargon dismissed stale reviews from Jim8y and cschuchardt88 via b727c3b July 30, 2024 08:21
@shargon shargon merged commit 450cb61 into master Jul 30, 2024
6 checks passed
@shargon shargon deleted the rpc-getversion branch July 30, 2024 17:29
@roman-khimov roman-khimov mentioned this pull request Jul 30, 2024
Closed
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Jul 31, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
934c704 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Jul 31, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
77b1212 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Jim8y added a commit to Jim8y/neo that referenced this pull request Aug 1, 2024
@Jim8y
Merge branch 'master' into fix-compound-reference
38c3c16 
* master:
  [Neo Core Add] add char support (neo-project#3441)
  [rpc] Extend `getversion` RPC response with additional protocol settings (neo-project#3443)
  update benchmark system (neo-project#3442)
  [`Optimization`] Parsing Smart Contract Script Analysis (neo-project#3420)
  `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (neo-project#3400)

# Conflicts:
#	benchmarks/Neo.Benchmarks/Benchmarks.POC.cs
#	benchmarks/Neo.VM.Benchmarks/Benchmarks.POC.cs
#	benchmarks/Neo.VM.Benchmarks/Program.cs
Jim8y added a commit to Jim8y/neo that referenced this pull request Aug 2, 2024
@Jim8y
Merge branch 'standardize-exception' of github.com:Jim8y/neo into sta…
449adc0 
…ndardize-exception

* 'standardize-exception' of github.com:Jim8y/neo:
  Clean using
  [Neo Core Add] add char support (neo-project#3441)
  [rpc] Extend `getversion` RPC response with additional protocol settings (neo-project#3443)
  update benchmark system (neo-project#3442)
  [`Optimization`] Parsing Smart Contract Script Analysis (neo-project#3420)
  `[Move]` Part-3 Classes into Different Library - `Neo.Extensions` (neo-project#3400)
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Aug 8, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
b9c7144 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Aug 8, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
329a27e 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Aug 9, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
e69c25e 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Aug 9, 2024
@AliceInHunterland
rpcsrv: add seedlist and standbycommittee to getversion
9fb6d32 
Port neo-project/neo#3443.

Close #3538

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@ixje ixje mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@Jim8y Jim8y Jim8y approved these changes

@NGDAdmin NGDAdmin NGDAdmin approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 left review comments

Assignees
No one assigned
Labels
ready to merge waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend getversion RPC response with additional protocol settings
5 participants
@shargon @Jim8y @cschuchardt88 @roman-khimov @NGDAdmin