add SettingsCheckbox components

[GretaD]

No description provided.

[georgehrke]

Also, you can't trigger it by clicking enter.

You can check here how to do it: https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/ActionCheckbox/ActionCheckbox.vue#L44

[skjnldsv]

Great work @GretaD :)

We should maybe remove the SettingCheckbow component, now, no?
Or make it use the Checkbox one?

[GretaD]

Great work @GretaD :)

We should maybe remove the SettingCheckbow component, now, no?
Or make it use the Checkbox one?

Yes we should remove it, i thought i did 🐐

[GretaD]

Thank you Barth for the review. I will change them asap, but can you please have a general review and decide what you think is fine and what it is not, so i can change everything in one push? You reviewed this PR many times, and every time you found something new, which is fine, but why not adding all the changes in the first review. Let me know if you're done so i can push the changes. Thanks again.

[skjnldsv]

You reviewed this PR many times, and every time you found something new, which is fine, but why not adding all the changes in the first review. Let me know if you're done so i can push the changes.

Sorry 🙈
Yes, it should be fine after the last changes I think :)
You're getting close!! 💪

[skjnldsv]

Did you lose some code while rebasing or something?
This seems unrelated now?

[skjnldsv]

checkedTarget is undefined

Suggested change

	<template>
	<Checkbox
	label="some text"
	v-model="checkedTarget"/>
	</template>
	<template>
	<Checkbox
	label="some text"
	v-model="checkedTarget"/>
	</template>
	<script>
	export default {
	data() {
	return {
	checkedTarget: false
	}
	},
	}
	</script>

[skjnldsv]

Design is off and not fitting the nextcloud checkbox design

This pr:

Wanted:

[skjnldsv]

and every time you found something new, which is fine, but why not adding all the changes in the first review

I think this is because this pr changed so much I find new stuff every time.
Please start over and check this is exactly done and working as it is supposed to.
I don't understand what happened to be honest 😕

[GretaD]

@skjnldsv what do you think about closing this one and I start a new one when i have the time to start and finish it on time. This is getting very old. And i can add your suggestions on the new one.

[GretaD]

closing to open a new one