Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase checkbox spacing to have a 44px click handler #10617

Closed
juliushaertl opened this issue Aug 9, 2018 · 6 comments
Closed

Increase checkbox spacing to have a 44px click handler #10617

juliushaertl opened this issue Aug 9, 2018 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: accessibility

Comments

@juliushaertl
Copy link
Member

From #10094:

Padding for checkbox settings (bottom left Files settings, Files sidebar link share options, Sharing settings): every entry needs at least 44px height for clickability, and more whitespace between checkbox and text
Sharing: More padding for checkbox entries, 44px as usual

We should add a padding to all checkboxes with their labels in the global input css, but I would suggest to do this for 15, since i would expect this might cause quite some bugs all over the places where the checkboxes are used.

@juliushaertl juliushaertl added this to the Nextcloud 15 milestone Aug 9, 2018
@juliushaertl juliushaertl added enhancement design Design, UI, UX, etc. labels Aug 9, 2018
@juliushaertl juliushaertl changed the title Increase checkbox spacing have a to 44px click handler Increase checkbox spacing to have a 44px click handler Aug 9, 2018
@nextcloud-bot

This comment has been minimized.

@MorrisJobke
Copy link
Member

@nextcloud/designers Should we still do this? Then we would need to do it until Wednesday (it should be merged by then).

@MorrisJobke
Copy link
Member

This seems similar to #7481

@MorrisJobke
Copy link
Member

Moved to 16.

@MorrisJobke MorrisJobke modified the milestones: Nextcloud 16, Nextcloud 17 Mar 6, 2019
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@skjnldsv skjnldsv removed this from the Nextcloud 17.0.7 milestone Apr 27, 2020
@skjnldsv
Copy link
Member

I guess we could start with nextcloud-libraries/nextcloud-vue#649 ?

jancborchardt added a commit that referenced this issue Aug 21, 2020
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@juliushaertl
Copy link
Member Author

We're back to smaller click targets but most of it is handled by the library today. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: accessibility
Projects
None yet
Development

No branches or pull requests

6 participants