add redirect info to external link

[tobiasKaminsky]

• Needs: Add redirect info to external link android-library#157

Latest external app allows to choose if external site can be embedded or not, so this reflects the setting:

• enabled: show internal
• disabled: open up in browser, ask if no default/multiple apps can handle it

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[codecov]

Codecov Report

Merging #2864 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2864      +/-   ##
=========================================
+ Coverage    6.44%   6.44%   +<.01%     
=========================================
  Files         296     296              
  Lines       29653   29668      +15     
  Branches     4286    4290       +4     
=========================================
+ Hits         1911    1913       +2     
- Misses      27457   27470      +13     
  Partials      285     285

Impacted Files	Coverage Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	88% <ø> (ø)	⬆️
...wncloud/android/providers/FileContentProvider.java	16.86% <0%> (-0.23%)	⬇️
...cloud/android/datamodel/ExternalLinksProvider.java	0% <0%> (ø)	⬆️
...m/owncloud/android/ui/activity/DrawerActivity.java	0% <0%> (ø)	⬆️
.../third_parties/daveKoeller/AlphanumComparator.java	82.75% <0%> (+1.14%)	⬆️
...cloud/android/datamodel/ArbitraryDataProvider.java	12.65% <0%> (+1.26%)	⬆️

[AndyScherzinger]

👍 looks good to me code-wise while I am not sure "redirect" is the right word since I always think it is a http-redirect which it is not, but I am okay with keeping the name, no better term in mind...

[tobiasKaminsky]

@AndyScherzinger I just took the name from upstream/app, while I agree that this is not the perfect name (on web UI it makes a bit more sense, as either the url is shown inline, or the user is redirected to the desired page).

[AndyScherzinger]

👍 just tested with the latest rebase, works fine

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	93	93
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	165
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	160
Security Warnings	163
Dodgy code Warnings	135
Total	692

[AndyScherzinger]

merging with a single approval since Mario is not available for reviews atm