-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve share link handling #2935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2935 +/- ##
=========================================
+ Coverage 6.52% 6.52% +<.01%
=========================================
Files 301 301
Lines 29734 29755 +21
Branches 4296 4298 +2
=========================================
+ Hits 1941 1943 +2
- Misses 27501 27521 +20
+ Partials 292 291 -1
|
👍 code is fine with me and also successfully tested on OP3T. I added some theming code for the snackbar's action. cc @tobiasKaminsky for review and approval. I vote to sneak this into 3.3.0 :) |
66564e6
to
84557b6
Compare
@tobiasKaminsky rebased to latest master ❗ |
84557b6
to
19ee0c4
Compare
19ee0c4
to
5d6c01e
Compare
|
I'll fix that, it is a bug always been there |
@tobiasKaminsky thanks for the thorough testing 👍 I fixed the issue you found via 1a565d2 |
👍 Thanks for the fix, working now as expected @tilosp thanks again for this PR 🎉 |
Signed-off-by: Tilo Spannagel <development@tilosp.de>
1a565d2
to
6ae7935
Compare
Lint
FindBugs (new)
FindBugs (master)
|
Resolves #2742