Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example donation links to info.xml #49

Closed
wants to merge 2 commits into from
Closed

Conversation

edward-ly
Copy link

This is just for testing that validation works for the donation attribute for now, but in the future, it would be nice if users could be able to specify the links themselves from the app skeleton generator form in the app store. This PR (or rather, just 5eea581) could then be merged if that happens.

Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
@provokateurin
Copy link
Member

In general it is a good idea to advertise this, but given nextcloud/appstore#1488 (comment) these fields would keep the placeholder values and I'd expect many people to forget removing them. We would likely end up with a few apps having these example donation links which is bad.

@provokateurin
Copy link
Member

Btw if you want to do the schema validation locally you can just use xmllint for that.

@edward-ly
Copy link
Author

Btw if you want to do the schema validation locally you can just use xmllint for that.

Thanks for the tip, and sorry about that. It was the quickest solution I could think of in the moment.

In general it is a good idea to advertise this, but given nextcloud/appstore#1488 (comment) these fields would keep the placeholder values and I'd expect many people to forget removing them. We would likely end up with a few apps having these example donation links which is bad.

I was thinking that the app skeleton generator would remove them automatically, but I just remembered that anyone can just clone this repository too, so yeah, closing this because of that too.

@edward-ly edward-ly closed this Sep 16, 2024
@edward-ly edward-ly deleted the feat/donation-links branch September 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants