Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xml): correct donation attribute type #1487

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(xml): correct donation attribute type #1487

merged 1 commit into from
Sep 16, 2024

Conversation

edward-ly
Copy link
Contributor

Fixes #1484, lightly tested in nextcloud/app_template#49.

@edward-ly
fix(xml): correct donation attribute type
39d435a 
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly mentioned this pull request Sep 16, 2024
Closed
bigcat88
bigcat88 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edward-ly edward-ly merged commit aa94b6d into master Sep 16, 2024
9 checks passed
@edward-ly edward-ly deleted the fix/donation-type branch September 16, 2024 12:10
@edward-ly
Copy link
Contributor Author

@bigcat88 thanks, might be best to deploy as soon as possible?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

info.xml: donation => The attribute 'title' is not allowed.
2 participants
@edward-ly @bigcat88