Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue 1044 by letting the 'localContact' update #1049

Closed
wants to merge 2 commits into from
Closed

Fixing issue 1044 by letting the 'localContact' update #1049

wants to merge 2 commits into from

Conversation

rponline
Copy link

@rponline rponline commented Apr 9, 2019 •
edited by skjnldsv
Loading

fix #1044

@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #1049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1049   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9025c...b0e8b73. Read the comment docs.

@skjnldsv skjnldsv self-requested a review April 9, 2019 05:35
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Apr 9, 2019
@skjnldsv skjnldsv added this to the next milestone Apr 9, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Apr 9, 2019

Hello @rponline !
Thanks a lot for taking care of this bug!!

I'll do some reviewing of it today! 🎉 🤗

skjnldsv
skjnldsv reviewed Apr 9, 2019
View reviewed changes
src/components/ContactDetails.vue
@@ -392,6 +392,7 @@ export default {
this.fixed = false
this.loadingUpdate = true
await this.$store.dispatch('updateContact', this.localContact)
this.updateLocalContact()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this will erase any changes made during the firing of updateContact and the updateLocalContact. On small connexion this could cause some data loss. Like you're writing a note, and the update gets fired, but you keep writing. When the updateLocalContact is reached, everything you kept writing will go back to the original state of the contact (not local) 🤔

I need to check if my theory is good :)

skjnldsv
skjnldsv requested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peek 09-04-2019 07-45
Yep confirmed! :(
We need to find another solution :)

@skjnldsv
Copy link
Member

skjnldsv commented Apr 9, 2019

Closing in favour of #1050
@rponline @caugner could you take a look and test please? :)

@rponline
Copy link
Author

rponline commented Apr 9, 2019 •
edited
Loading

ok, thx for the review!

@rponline rponline closed this Apr 9, 2019
@skjnldsv skjnldsv removed this from the next milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv requested changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New contact: TEL, EMAIL and ADR cannot be removed together
2 participants
@rponline @skjnldsv