Use localcontact as default changes on properties

[skjnldsv]

Fix #1044

@rponline @caugner

[codecov]

Codecov Report

Merging #1050 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1050   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9025c...6a908b3. Read the comment docs.

[rponline]

Ok, it's working!

The only thing worth mentioning:
The viewport always scrolls on top when deleting a property.

[skjnldsv]

@rponline nice catch! :)
We need to prevent the action indeed!

[skjnldsv]

@rponline fix is in nextcloud-libraries/nextcloud-vue#342
Let's review and merge this one :)

[rponline]

I somehow can't use a custom version of nextcloud-vue.

I tried:

• cloning nextcloud-vue and building it: make build-js
• Adding the path of the git working directory of nextcloud-vue to the package.json of the contacts app: "nextcloud-vue": "~/git-projects/nextcloud-vue",
• building the contacts app: make build-js

I also tried make build-js-production and make watch-js ... and deleting package-lock.json .. and node_modules

Is there a howto for setting up a working develeopment environment focusing on npm?

[skjnldsv]

@rponline just do make :)
https://github.com/nextcloud/contacts#build-the-app

EDIT: ah sorry, I misread, you're talking about nextcloud-vue!

1. on the git cloned directory of nextcloud-vue, do make then npm link
2. on the contacts repo do: npm install then npm link nextcloud-vue
3. on the contacts repo still: make build-js or make build-js-production

Or manually copy the dist folder from nextcloud-vue onto the contacts node_modules/nextcloud-vue folder (and erase existing files)

[rponline]

I can't test this for reasons I don't understand.

after using npm link, the contacts JS is not compiling anymore:

Without using npm link (and just copying the dist/ content), js compiles, but the contacts app is not working anymore: It just stops doing stuff and shows a blank page:

Same behavior when i just use the master branch of nextcloud-vue ...
I don't know what's wrong with my environment or what I'm doing wrong.

Someone else should test it instead, please :) (@caugner ?)

[skjnldsv]

Hum, I had that once.
Ignore it, yo can still test this pr without the nextcloud-vue part.

Just ignore the viewport issue, i'll be fixed automatically once we released a new nextcloud-vue release :)

[rponline]

Ignoring the whole scrolling issue:
yes, it's working :)