missing translation for 'Add a new stack' #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 72.34% 72.34%
=======================================
Files 32 32
Lines 846 846
=======================================
Hits 612 612
Misses 234 234 |
pixelipo
requested changes
May 30, 2017
|
@pixelipo you are right! Thanks! |
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
pixelipo
approved these changes
May 30, 2017
pixelipo
requested changes
May 30, 2017
templates/part.boardlist.php
Outdated
| @@ -3,7 +3,7 @@ | |||
| <thead> | |||
| <tr> | |||
| <td class="cell-board-bullet"></td> | |||
| <td class="cell-board-title" width="90%"><?php p($l->t('Board title')); ?></td> | |||
| <td class="cell-board-title" width="90%"><?php p($l->t('Boards')); ?></td> | |||
There was a problem hiding this comment.
I don't think this is correct, @artemanufrij - it's a row title, and the row displays board titles.
There was a problem hiding this comment.
@juliushaertl what do you think about?
There was a problem hiding this comment.
@pixelipo @juliushaertl may be just "Title"?
Title Members
There was a problem hiding this comment.
Title is better.
By the way, Files app uses Name for the same row in their table
There was a problem hiding this comment.
@pixelipo ok, I change it to"Title"
There was a problem hiding this comment.
Yep just title sounds better.
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
pixelipo
approved these changes
May 31, 2017
Signed-off-by: Artem Anufrij <artem.anufrij@live.de> fixed pixelipo's comment label->tag Signed-off-by: Artem Anufrij <artem.anufrij@live.de> 'Board title' -> 'New Board title' Signed-off-by: Artem Anufrij <artem.anufrij@live.de> 'Board title' -> 'Boards' in Boardlist Signed-off-by: Artem Anufrij <artem.anufrij@live.de> [tx-robot] updated from transifex renamed column header 'Boards' -> 'Title' Signed-off-by: Artem Anufrij <artem.anufrij@live.de> Merge branch 'master' into missing_translation
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
pixelipo
reviewed
Jun 1, 2017
templates/part.board.mainView.php
Outdated
| @@ -34,10 +34,10 @@ | |||
| <div class="stack" ng-repeat="s in stacks" data-as-sortable-item | |||
| data-columnindex="{{$index}}" id="column{{$index}}" | |||
| style=""> | |||
| <h2 data-as-sortable-item-handle> | |||
| <h2 data-as-sortable-item-handle> | |||
There was a problem hiding this comment.
you got some weird space left before the <h2> tag
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
juliushaertl
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Anufrij artem.anufrij@live.de