Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing translation for 'Add a new stack' #169

Merged
merged 13 commits into from
Jun 6, 2017
Merged

missing translation for 'Add a new stack' #169

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6100fce
missing translation for 'Add a new stack'
artemanufrij May 30, 2017
26ac683
fixed pixelipo's comment
artemanufrij May 30, 2017
a6e60f6
label->tag
artemanufrij May 30, 2017
b56c4f4
'Board title' -> 'New Board title'
artemanufrij May 30, 2017
2cf39cc
'Board title' -> 'Boards' in Boardlist
artemanufrij May 30, 2017
a4fe53f
renamed column header 'Boards' -> 'Title'
artemanufrij May 31, 2017
ad926a0
Merge branch 'master' into missing_translation
artemanufrij Jun 1, 2017
5f3f395
missing translation for 'Add a new stack'
artemanufrij Jun 1, 2017
f33fe19
Merge remote-tracking branch 'origin/missing_translation' into missin…
artemanufrij Jun 1, 2017
763afaa
Merge branch 'master' into missing_translation
artemanufrij Jun 1, 2017
7fe3fc7
fixed h2 tag
artemanufrij Jun 1, 2017
eba32b1
fixed space
artemanufrij Jun 1, 2017
c01b684
Merge branch 'master' into missing_translation
juliushaertl Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
'Board title' -> 'Boards' in Boardlist 
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
  • Loading branch information
@artemanufrij
artemanufrij committed May 30, 2017
commit 2cf39ccd9f7661814355474769dc796b1a68273d
2 changes: 1 addition & 1 deletion templates/part.boardlist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<thead>
<tr>
<td class="cell-board-bullet"></td>
<td class="cell-board-title" width="90%"><?php p($l->t('Board title')); ?></td>
<td class="cell-board-title" width="90%"><?php p($l->t('Boards')); ?></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, @artemanufrij - it's a row title, and the row displays board titles.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl what do you think about?

Copy link
Member Author

@artemanufrij artemanufrij May 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixelipo @juliushaertl may be just "Title"?

Title Members

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is better.

By the way, Files app uses Name for the same row in their table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixelipo ok, I change it to"Title"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep just title sounds better.

<td class="cell-board-members"><?php p($l->t('Members')); ?></td>
</tr>
</thead>
Expand Down