Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old forms tables #1156

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Remove old forms tables #1156

merged 1 commit into from
Apr 11, 2022

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Apr 2, 2022

In case somebody has still the old tables of Forms < v2 on DB, i think we can do a small cleanup now. 😉

Closes #1155

@jotoeri jotoeri added 3. to review Waiting for reviews technical debt Technical issue labels Apr 2, 2022
@jotoeri jotoeri added this to the 3.0 milestone Apr 2, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Apr 7, 2022

/rebase

@jotoeri jotoeri added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1156 (d53aa30) into master (fbc28f8) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1156      +/-   ##
============================================
- Coverage     29.14%   28.81%   -0.34%     
- Complexity      356      362       +6     
============================================
  Files            34       35       +1     
  Lines          1393     1409      +16     
============================================
  Hits            406      406              
- Misses          987     1003      +16     

@jotoeri jotoeri added the Do not merge Don't merge, as it will break master (e.g. due to pending dependency) label Apr 7, 2022
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked

@jotoeri jotoeri removed the Do not merge Don't merge, as it will break master (e.g. due to pending dependency) label Apr 8, 2022
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri merged commit 19d77a8 into master Apr 11, 2022
@jotoeri jotoeri deleted the fix/del_old_tables branch April 11, 2022 17:44
@jotoeri jotoeri mentioned this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop old forms tables
2 participants