-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unread mail dashboard widget #4124
Conversation
b59ac14
to
01d8b27
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
01d8b27
to
a77aed8
Compare
Apparently, the coverage shrinks by 0.03% because the dashboard widgets are untested. @ChristophWurst I can add tests if you want me to but I don't think testing the dashboard widget is that useful. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 excellent code. Thanks a lot 🙏
This comment has been minimized.
This comment has been minimized.
@st3iny Good job! |
This comment has been minimized.
This comment has been minimized.
Nono, that is fine. I wish there was a threshold to set until which it's fine to have the coverage decrease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is good, the error i reported was not because of this PR. Thanks again Richard
@st3iny I would propose for consistency to show the unread messages on dashboard as bold. But we can merge this one and do that in another follow up PR. |
Please open a feature request about this, so our design lead can have a look. In general we like to split features (or/and bugs) for better reviewing and possible regressions. |
Ref #3742
Adds a second widget for showing unread mails from all inboxes. Extensively reuses the the code from Julius.
Here is a screenshot (mails are blurred for privacy reasons):