Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unread mail dashboard widget #4124

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 24, 2020

Ref #3742

Adds a second widget for showing unread mails from all inboxes. Extensively reuses the the code from Julius.

Here is a screenshot (mails are blurred for privacy reasons):
unread-mail-widget

@st3iny st3iny self-assigned this Nov 24, 2020
@st3iny st3iny force-pushed the enhancement/3742/unread-mail-on-dashboard branch from b59ac14 to 01d8b27 Compare November 24, 2020 15:30
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the enhancement/3742/unread-mail-on-dashboard branch from 01d8b27 to a77aed8 Compare November 24, 2020 15:35
@st3iny st3iny marked this pull request as ready for review November 24, 2020 15:55
@st3iny
Copy link
Member Author

st3iny commented Nov 24, 2020

Apparently, the coverage shrinks by 0.03% because the dashboard widgets are untested.

@ChristophWurst I can add tests if you want me to but I don't think testing the dashboard widget is that useful.

@GretaD

This comment has been minimized.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 excellent code. Thanks a lot 🙏

src/main-dashboard.js Show resolved Hide resolved
@ChristophWurst

This comment has been minimized.

@jakobroehrl
Copy link

@st3iny Good job!
What about showing favourite mails in this list, too?

@st3iny

This comment has been minimized.

@ChristophWurst
Copy link
Member

Apparently, the coverage shrinks by 0.03% because the dashboard widgets are untested.

@ChristophWurst I can add tests if you want me to but I don't think testing the dashboard widget is that useful.

Nono, that is fine. I wish there was a threshold to set until which it's fine to have the coverage decrease.

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good, the error i reported was not because of this PR. Thanks again Richard

@GretaD
Copy link
Contributor

GretaD commented Nov 25, 2020

@st3iny I would propose for consistency to show the unread messages on dashboard as bold. But we can merge this one and do that in another follow up PR.

@GretaD
Copy link
Contributor

GretaD commented Nov 25, 2020

@st3iny Good job!
What about showing favourite mails in this list, too?

Please open a feature request about this, so our design lead can have a look. In general we like to split features (or/and bugs) for better reviewing and possible regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants