Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined isDirectoryHandle() method breaking encryption. #10430

Closed
MartB opened this issue Jul 27, 2018 · 28 comments
Closed

Undefined isDirectoryHandle() method breaking encryption. #10430

MartB opened this issue Jul 27, 2018 · 28 comments

Comments

@MartB
Copy link
Member

MartB commented Jul 27, 2018

if (self::isDirectoryHandle($source)) {

Error: Call to undefined method OC\Files\Stream\Encryption::isDirectoryHandle()
/usr/share/nginx/cloud.familie-boeh.de/lib/private/Files/Stream/Encryption.php - line 181:

OC\Files\Stream\Encryption::wrapSource(null, null, "ocencryption", "OC\\Files\\Stream\\Encryption", "r")

Workaround:
Disable the External Files Application as specified here: #10430 (comment)

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #5944 (Encryption error.), #8346 (occ encryption:migrate is broken (as of v13.0.0)), #4319 (Call to undefined method OCP\Defaults::shouldReplaceIcons()), #8420 (NC13 - Call to undefined method OC_Defaults::replaceImagePath()), and #9693 (Logcondition broken).

@MartB
Copy link
Member Author

MartB commented Jul 27, 2018

@nextcloud-bot unrelated, this defect has been there since april i wonder why it didnt pop up during testing. Did someone remove that method lately or is noone using encryption in their test environments?

@rullzer
Copy link
Member

rullzer commented Jul 30, 2018

@nextcloud/encryption please have a look

@schiessle
Copy link
Member

I can't reproduce it. The method isDirectoryHandle() is implemented in the parent class https://github.com/nextcloud/3rdparty/blob/4b46a9176e392932702be12060a8c5899e092174/icewind/streams/src/Wrapper.php#L47 and gets called as expected on my test system.

Can you double check that this class and this method exists on your system as well?

@schiessle
Copy link
Member

I just checked the Nextcloud 14 beta1 zip file and it contains the file and the method as well. How did you installed it?

@MartB
Copy link
Member Author

MartB commented Aug 1, 2018

I updated it using the official updater on beta channel.

Edit:
The file you are referencing exists, but its not being used by my nextcloud instance.
See the file i referenced in my first post, adding the method there seems to fix it.

PHP Infos:

PHP 7.2.8 (cli) (built: Jul 17 2018 05:35:43) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.8, Copyright (c) 1999-2018, by Zend Technologies

@TecJon
Copy link

TecJon commented Aug 1, 2018

@schiessle I am getting the same error message. I have tested it using a one-click fresh install on shared web space and upgrading to NC 14 beta 1. I also tested it on fresh install on a virtual server, code directly from nextcloud.com.

Indeed the function exists in 3rdparty/icewind/streams/src/Wrapper.php. I double checked.

Here's the detailed nextcloud.log:

{"reqId":"W2HSqNUVmbtbtaKMWYZI1AAAAA8","level":3,"time":"2018-08-01T15:32:56+00:00","remoteAddr":"xx.xxx.x.xx","user":"User","app":"remote","method":"PUT","url":"\/cloud\/remote.php\/dav\/files\/User\/AmazonS3\/New%20folder\/test.txt","message":{"Exception":"Error","Message":"Call to undefined method OC\\Files\\Stream\\Encryption::isDirectoryHandle()","Code":0,"Trace":[{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Stream\/Encryption.php","line":184,"function":"wrapSource","class":"OC\\Files\\Stream\\Encryption","type":"::","args":[null,null,"ocencryption","OC\\Files\\Stream\\Encryption","wb"]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php","line":468,"function":"wrap","class":"OC\\Files\\Stream\\Encryption","type":"::","args":[null,"New folder\/test.txt","\/User\/files\/AmazonS3\/New folder\/test.txt",[],"User",{"__class__":"OCA\\Encryption\\Crypto\\Encryption"},{"cache":null,"scanner":null,"watcher":null,"propagator":null,"updater":null,"__class__":"OC\\Files\\Storage\\Wrapper\\Availability"},{"cache":{"__class__":"OC\\Files\\Cache\\Cache"},"scanner":null,"watcher":null,"propagator":null,"updater":null,"__class__":"OC\\Files\\Storage\\Wrapper\\Encryption"},{"__class__":"OC\\Encryption\\Util"},{"__class__":"OC\\Encryption\\File"},"wb",0,0,0,true]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Storage\/Wrapper\/Wrapper.php","line":298,"function":"fopen","class":"OC\\Files\\Storage\\Wrapper\\Encryption","type":"->","args":["New folder\/test.txt","wb"]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/dav\/lib\/Connector\/Sabre\/File.php","line":168,"function":"fopen","class":"OC\\Files\\Storage\\Wrapper\\Wrapper","type":"->","args":["New folder\/test.txt","wb"]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/dav\/lib\/Connector\/Sabre\/Directory.php","line":156,"function":"put","class":"OCA\\DAV\\Connector\\Sabre\\File","type":"->","args":[null]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php","line":1096,"function":"createFile","class":"OCA\\DAV\\Connector\\Sabre\\Directory","type":"->","args":["test.txt",null]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/CorePlugin.php","line":529,"function":"createFile","class":"Sabre\\DAV\\Server","type":"->","args":["files\/User\/AmazonS3\/New folder\/test.txt",null,null]},{"function":"httpPut","class":"Sabre\\DAV\\CorePlugin","type":"->","args":[{"absoluteUrl":"https:\/\/example.com\/cloud\/remote.php\/dav\/files\/User\/AmazonS3\/New%20folder\/test.txt","__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/sabre\/event\/lib\/EventEmitterTrait.php","line":105,"function":"call_user_func_array","args":[[{"__class__":"Sabre\\DAV\\CorePlugin"},"httpPut"],[{"absoluteUrl":"https:\/\/example.com\/cloud\/remote.php\/dav\/files\/User\/AmazonS3\/New%20folder\/test.txt","__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php","line":479,"function":"emit","class":"Sabre\\Event\\EventEmitter","type":"->","args":["method:PUT",[{"absoluteUrl":"https:\/\/example.com\/cloud\/remote.php\/dav\/files\/User\/AmazonS3\/New%20folder\/test.txt","__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php","line":254,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->","args":[{"absoluteUrl":"https:\/\/example.com\/cloud\/remote.php\/dav\/files\/User\/AmazonS3\/New%20folder\/test.txt","__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/dav\/lib\/Server.php","line":293,"function":"exec","class":"Sabre\\DAV\\Server","type":"->","args":[]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/dav\/appinfo\/v2\/remote.php","line":35,"function":"exec","class":"OCA\\DAV\\Server","type":"->","args":[]},{"file":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/remote.php","line":163,"args":["\/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/dav\/appinfo\/v2\/remote.php"],"function":"require_once"}],"File":"\/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Stream\/Encryption.php","Line":201,"CustomMessage":"--"},"userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko\/20100101 Firefox\/61.0","version":"14.0.0.13"}

Followed by the following error:

{"reqId":"W2HSrsJfIeHnvm09TQXA6wAAAA8","level":3,"time":"2018-08-01T15:33:02+00:00","remoteAddr":"xx.xxx.x.xx","user":"User","app":"PHP","method":"GET","url":"\/cloud\/index.php\/settings\/user","message":"Uncaught Error: Class 'Aws\\S3\\ObjectUploader' not found in \/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/aws\/aws-sdk-php\/src\/S3\/S3ClientTrait.php:46\nStack trace:\n#0 \/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/aws\/aws-sdk-php\/src\/S3\/S3ClientTrait.php(32): Aws\\S3\\S3Client->uploadAsync('containername', 'New folder\/test...', false, 'private', Array)\n#1 \/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/ObjectStore\/S3ObjectTrait.php(77): Aws\\S3\\S3Client->upload('containername', 'New folder\/test...', false, 'private', Array)\n#2 \/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/files_external\/lib\/Lib\/Storage\/AmazonS3.php(589): OCA\\Files_External\\Lib\\Storage\\AmazonS3->writeObject('New folder\/test...', false)\n#3 \/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/files_external\/lib\/Lib\/Storage\/AmazonS3.php(419): OCA\\Files_External\\Lib\\Storage\\AmazonS3->writeBack('\/www\/htdocs\/w01...', 'New folder\/test...')\n#4 [internal function]: OCA\\Files_External\\Lib\\Storage\\AmazonS3->OCA\\Files_External\\Lib\\Storage\\{closure} at \/www\/htdocs\/w5487967f\/example.com\/cloud\/3rdparty\/aws\/aws-sdk-php\/src\/S3\/S3ClientTrait.php#46","userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko\/20100101 Firefox\/61.0","version":"14.0.0.13"}

@MartB
Copy link
Member Author

MartB commented Aug 1, 2018

Hypothesis:
This seems to be broken on File shares (by link) and webdav but not in nextcloud itself.

@TecJon
Copy link

TecJon commented Aug 1, 2018

See the file i referenced in my first post, adding the method there seems to fix it.

I can confirm this. The upload finishes and the file appears in the web interface.
It is still odd though. Both test installations are extremely slow and result in many timeouts when working with s3.

The uploaded image cannot be opened. Error:
{"reqId":"W2HcWVcELLfCRg9OWZC3LgAAAcE","level":3,"time":"2018-08-01T16:14:18+00:00","remoteAddr":"xx.xxx.x.xx","user":"User","app":"PHP","method":"GET","url":"\/cloud\/index.php\/apps\/logreader\/poll?lastReqId=W2HbmVcELLfCRg9OWZC20AAAAN8","message":"Uncaught Error: Access to undeclared static property: OC\\Files\\Filesystem::$normalizedPathCache in \/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Filesystem.php:797\nStack trace:\n#0 \/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/View.php(2056): OC\\Files\\Filesystem::normalizePath('\/User\/files\/Am...')\n#1 \/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/View.php(1180): OC\\Files\\View->unlockFile('\/AmazonS3\/test2...', 1)\n#2 [internal function]: OC\\Files\\View->OC\\Files\\{closure}()\n#3 \/www\/htdocs\/w5487967f\/example.com\/cloud\/apps\/files_external\/3rdparty\/icewind\/streams\/src\/CallbackWrapper.php(109): call_user_func(Object(Closure))\n#4 [internal function]: Icewind\\Streams\\CallbackWrapper->stream_close()\n#5 {main}\n thrown at \/www\/htdocs\/w5487967f\/example.com\/cloud\/lib\/private\/Files\/Filesystem.php#797","userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko\/20100101 Firefox\/61.0","version":"14.0.0.13"}

Opening a uploaded text file opens a alert box "missing signature".

Which is again #8299 probably.

@schiessle
Copy link
Member

@MartB

Hypothesis:
This seems to be broken on File shares (by link) and webdav but not in nextcloud itself.

I tried it now with a shared folder access/update/upload files by another user, on a public page and via webdav... all operations work here.

I tried it with 14.0.0 beta 1 from git and from the original zip file downloaded here: https://help.nextcloud.com/t/nextcloud-14-0-0-beta-1-is-here/34424

can you please try to describe the exact steps which lead to this error for you? Thanks!

@MartB
Copy link
Member Author

MartB commented Aug 2, 2018

The heck...

Edit: i submitted this way too early lol.

Environment:

  • enabled encryption
  • shared folder inside another shared folder

Steps to replicate:

  • accessing any file inside the shared folder throws the error and returns invalid response.

Edit2: beta2 shows the same symptoms.

@schiessle
Copy link
Member

schiessle commented Aug 2, 2018

Ok, what I did now:

  1. Install Nextcloud 14 beta2
  2. Enable encryption and load the default encryption module
  3. create two more users (user2 and user3)
  4. user1 created /folder1/folder2/test.txt
  5. user1 shares folder1 to user2
  6. login as user2
  7. user2 can read folder1/folder2/test.txt
  8. user2 shares folder2 to user3
  9. login as user3
  10. user3 can read folder2/test.txt
  11. user3 creates folder2/test2.txt
  12. login as user2
  13. user2 can read folder1/folder2/test2.txt
  14. login as user1
  15. user1 can read folder1/folder2/test2.txt

Is this all correct? At which point does it break for you?

To be honest, I also don't see why the server shouldn't find a method in a class based on the way a file was shared.

@MartB
Copy link
Member Author

MartB commented Aug 2, 2018

I cant really reproduce this with a fresh install (due to lack of time), but my playground instance on my public facing server which is experiencing said issue was always getting upgraded through the updater.

Did you try to share by public url, thats what seems to be broken for me.
Everything i do inside the actual nextcloud interface while logged in seems to work.

Trust me this is annoying and i totally understand it sounds weird but it only popped up after i updated to beta 14 so it must be related to nextcloud or the update process.

@schiessle
Copy link
Member

Did you try to share by public url, thats what seems to be broken for me.

yes, I shared a folder as public link and both downloaded and uploaded files successfully over the public link.

Do you use any special external storage, 3rdparty apps,... etc?

@schiessle
Copy link
Member

@icewind1991 do you have any idea maybe?

@MartB
Copy link
Member Author

MartB commented Aug 4, 2018

@schiessle nothing really, im using the "local" storage only.

My encryption settings are:

  • Enable server-side encryption + Default enc. module
  • Encrypt the homestorage

Edit:
Files in my personal root folder within nextcloud work, if its nested it wont work anymore with the undefinedDirectory thing the heck is going on :octocat:

Edit2:
Full backtrace from an older log:

{"reqId":"3dmP2HW5YR0i1Zc2y80W","level":3,"time":"2018-08-04T14:19:22+00:00","remoteAddr":"2a01:5c0:e08d:31a0:d82b:a0ed:5c87:2de","user":"--","app":"index","method":"GET","url":"\/s\/bogTwqBqC3DbXc4\/download?path=%2Fdlcs&files=ex5_dv_extra_1.pdf","message":{"Exception":"Error","Message":"Call to undefined method OC\\Files\\Stream\\Encryption::isDirectoryHandle()","Code":0,"Trace":[{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/Stream\/Encryption.php","line":181,"function":"wrapSource","class":"OC\\Files\\Stream\\Encryption","type":"::","args":[null,null,"ocencryption","OC\\Files\\Stream\\Encryption","r"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php","line":468,"function":"wrap","class":"OC\\Files\\Stream\\Encryption","type":"::","args":[null,"files\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf","\/MartinB.\/files\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf",{"oc_encryption_module":"OC_DEFAULT_MODULE","cipher":"AES-256-CTR","signed":"true"},null,{"__class__":"OCA\\Encryption\\Crypto\\Encryption"},{"__class__":"OC\\Files\\Storage\\Home"},{"cache":null,"scanner":null,"watcher":null,"propagator":null,"updater":null,"__class__":"OC\\Files\\Storage\\Wrapper\\Encryption"},{"__class__":"OC\\Encryption\\Util"},{"__class__":"OC\\Encryption\\File"},"r",108820,74533,8192,true]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/Storage\/Wrapper\/Wrapper.php","line":298,"function":"fopen","class":"OC\\Files\\Storage\\Wrapper\\Encryption","type":"->","args":["files\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf","r"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/View.php","line":1144,"function":"fopen","class":"OC\\Files\\Storage\\Wrapper\\Wrapper","type":"->","args":["files\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf","r"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/View.php","line":986,"function":"basicOperation","class":"OC\\Files\\View","type":"->","args":["fopen","\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf",["read"],"r"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/View.php","line":422,"function":"fopen","class":"OC\\Files\\View","type":"->","args":["\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf","r"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/legacy\/files.php","line":330,"function":"readfile","class":"OC\\Files\\View","type":"->","args":["\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs\/ex5_dv_extra_1.pdf"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/legacy\/files.php","line":125,"function":"getSingleFile","class":"OC_Files","type":"::","args":[{"__class__":"OC\\Files\\View"},"\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs","ex5_dv_extra_1.pdf",{"head":false}]},{"file":"\/usr\/share\/nginx\/my.domain.de\/apps\/files_sharing\/lib\/Controller\/ShareController.php","line":543,"function":"get","class":"OC_Files","type":"::","args":["\/Uni\/Kosy Tutor\/KoSyCloud\/dlcs","ex5_dv_extra_1.pdf",{"head":false}]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":166,"function":"downloadShare","class":"OCA\\Files_Sharing\\Controller\\ShareController","type":"->","args":["bogTwqBqC3DbXc4","ex5_dv_extra_1.pdf","\/dlcs",""]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareController"},"downloadShare"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/AppFramework\/App.php","line":118,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareController"},"downloadShare"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/public\/AppFramework\/App.php","line":140,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["ShareController","downloadShare",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"}]},{"file":"\/usr\/share\/nginx\/my.domain.de\/core\/routes.php","line":171,"function":"dispatch","class":"OCP\\AppFramework\\App","type":"->","args":["ShareController","downloadShare"]},{"function":"{closure}","class":"OC\\Route\\Router","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"Closure"},"*** sensitive parameter replaced ***"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/lib\/base.php","line":989,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/s\/bogTwqBqC3DbXc4\/download"]},{"file":"\/usr\/share\/nginx\/my.domain.de\/index.php","line":42,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"\/usr\/share\/nginx\/my.domain.de\/lib\/private\/Files\/Stream\/Encryption.php","Line":198,"CustomMessage":"--"},"userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/68.0.3440.84 Safari\/537.36","version":"14.0.0.14"}

@ordinarygulp
Copy link

ordinarygulp commented Aug 5, 2018

Simple to reproduce, same as @MartB :

  • Clean install of the stable branch.
  • Enable encryption (default options checked).
  • Set branch to beta.
  • Run updater.
  • Profit. (Unable to upload new files, or download any files).
  • Tested on uploading a folder, and a .txt file to the root directory. 1 user installation, no sharing enabled.

Using Docker (Linuxserver container) with unRAID here. I reproduced this 2 times in a row.

@kesselb
Copy link
Contributor

kesselb commented Aug 5, 2018

There are two versions for Icewind\Streams:

The version in files_external is older and does not include "isDirectoryHandle". Maybe this is related to this issue.

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

Do you all run from git?
If so you need to update the submodules when changing branches.

@MartB
Copy link
Member Author

MartB commented Aug 6, 2018

@rullzer nope, just used the official updater from beta branch 13 to beta branch 14.

Maybe something is broken in these update archives?

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

@MartB unlikely as that is what @schiessle is using to test.

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

@schiessle can you try your steps with the files_external app enabled?

@schiessle
Copy link
Member

@rullzer that's it. As soon as I enable the external storage app I can reproduce it. Any idea how to fix this? The problem seems to be introduced with Nextcloud 14, I tried Nextcloud 13 and there it works also with external storages enabled.

@MartB
Copy link
Member Author

MartB commented Aug 6, 2018

@schiessle @rullzer 🙏
Glad you can reproduce it now.

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

@schiessle I think it is related to #10430 (comment) because they are not the same version.

Let me see if I can update it and get feedback from @icewind1991

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

Of course it probably make sense to just not ship it in the 3rdparty one... but lets see.

rullzer added a commit that referenced this issue Aug 6, 2018
Fixes #10430

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 14 milestone Aug 6, 2018
This was referenced Aug 6, 2018
@icewind1991
Copy link
Member

core also depends on it

weeman1337 pushed a commit that referenced this issue Aug 9, 2018
Fixes #10430

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@schiessle
Copy link
Member

This should be fixed now with Nextcloud 1 beta 3. Please re-open the ticket and/or reply here if the problem still persist for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants