Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icewind/streams #10548

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Update icewind/streams #10548

merged 1 commit into from
Aug 8, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 6, 2018

Fixes #10430

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #10430

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Aug 6, 2018

this should fix it. FOr 15 it would make sense to remove it from files_external I think...

@icewind1991
Copy link
Member

For dropping the duplicate dependency, it would probably be best to move icewind/smb from the files_external 3rdparty folder to the main one, composer isn't really made for the whole "multiple vendor folders" thing

@rullzer
Copy link
Member Author

rullzer commented Aug 7, 2018

@schiessle can you verify this fixes it?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 🐘

@rullzer rullzer merged commit 7648bb0 into master Aug 8, 2018
@rullzer rullzer deleted the fix/10430/update_icewind_streams branch August 8, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants