Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: files index load indefinitely -> Uncaught (in promise) TypeError: e.vm is null #32582

Closed
6 of 8 tasks
Ornanovitch opened this issue May 24, 2022 · 28 comments
Closed
6 of 8 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@Ornanovitch
Copy link
Contributor

Ornanovitch commented May 24, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Randomly (it seems), my files index (root folder) hangs on loading and I'm forced to click on the file app again to get it loaded. When it hangs, it doesn't help to just reload the page, as if I had to recall the home URL to get threw the full redirection steps.

No error into NC logs, but FF console shows this:

Uncaught (in promise) TypeError: e.vm is null
    attach files.js:173
    _parseFileInfo client.js:431
    He Underscore
    _parseFileInfo client.js:430
    _parseResult client.js:445
    qe Underscore
    _parseResult client.js:444
    getFolderContents client.js:529
    promise callback*getFolderContents client.js:527
    reload merged-index.js:6249
    changeDirectory merged-index.js:6103
    _onUrlChanged merged-index.js:4828
    Underscore 3
    jQuery 7
    _onPopState merged-index.js:362
    initialize merged-index.js:143
    <anonymous> merged-index.js:405
    Underscore 5
    <anonymous> merged-index.js:404
    EventListener.handleEvent* merged-index.js:401
files.js:173:6

Steps to reproduce

I don't know... just navigate :/ (see also #32582 (comment))

Expected behavior

My folder should load consistently.

Installation method

Manual installation

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated to a major version: 23.0.5 -> 24.0.1

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "24.0.1.1",
        "overwrite.cli.url": "https:\/\/localhost",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "default_language": "fr",
        "default_locale": "fr_FR",
        "default_phone_region": "FR",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED",
            "HTTP_FORWARDED_FOR"
        ],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "skeletondirectory": "\/etc\/nextcloud\/skeleton",
        "maintenance": false,
        "theme": "",
        "loglevel": 3,
        "updater.release.channel": "stable",
        "updater.secret": "***REMOVED SENSITIVE VALUE***",
        "app_install_overwrite": [
            "groupfolders"
        ]
    }
}

List of activated Apps

Enabled:
  - accessibility: 1.10.0
  - activity: 2.16.0
  - apporder: 0.15.0
  - audioplayer: 3.3.0
  - bookmarks: 10.3.1
  - calendar: 3.3.1
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contacts: 4.1.1
  - dav: 1.22.0
  - event_update_notification: 1.5.0
  - federatedfilesharing: 1.14.0
  - files: 1.19.0
  - files_pdfviewer: 2.5.0
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - groupfolders: 12.0.0
  - integration_gitlab: 1.0.3
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - nextcloud_announcements: 1.13.0
  - notes: 4.3.1
  - notifications: 2.12.0
  - oauth2: 1.12.0
  - password_policy: 1.14.0
  - photos: 1.6.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - richdocuments: 6.1.0
  - serverinfo: 1.14.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - side_menu: 2.3.5
  - support: 1.7.0
  - survey_client: 1.12.0
  - tasks: 0.14.4
  - text: 3.5.1
  - theming: 1.15.0
  - theming_customcss: 1.11.0
  - twofactor_backupcodes: 1.13.0
  - updatenotification: 1.14.0
  - user_saml: 5.0.0
  - viewer: 1.8.0
  - workflowengine: 2.6.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

None

Additional info

No response

@Ornanovitch Ornanovitch added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels May 24, 2022
@Ornanovitch
Copy link
Contributor Author

FWIW, it seems to happens quasi systematically (but not only ⚠️) when I start firefox with the NC's apps/files page attached to a pinned tab (in other words when the page is kind of preloaded).

@cetcondor
Copy link

Have the same issue on several instances. Different from @Ornanovitch in our deployments it's Apache instead of Nginx, and regarding the user-backends, SSO-SAML is not activated.

@effatee
Copy link

effatee commented May 31, 2022

Yes same issue here as well.
No specific error caught or raised in the logging.
Just indefinite loading logo, and a click on the "house" breadcrumb is required to load files.

@melroy89
Copy link
Contributor

melroy89 commented Jun 6, 2022

I can confirm this issue as well. Page will not load, until refresh and trying again from scratch.

Uncaught (in promise) TypeError: e.vm is null
    attach files.js:173
    _parseFileInfo client.js:431
    He Underscore
    _parseFileInfo client.js:430
    _parseResult client.js:445
    qe Underscore
    _parseResult client.js:444
    getFolderContents client.js:529
files.js:173:6

image

@Mer0me
Copy link

Mer0me commented Jun 7, 2022

Some of our users have the very same problem here since v24 :

  • Clicking on Files app shows infinite spinner very often but not systematically
  • Clicking on the home button works immediately
  • Uncaught (in promise) TypeError: e.vm is null in the console log

We are all using Firefox 91.8.0 ESR on the same network and the same instance of Nextcloud, but only some users have this behavior. Using the impersonate app to reproduce the bug on a non-affected computer doesn't work : bug is not related to user profile, it seems to be browser-related. We cannot reproduce the bug under Chrome.
Maybe a cache issue ?

@Ornanovitch
Copy link
Contributor Author

We are all using Firefox 91.8.0 ESR [...] We cannot reproduce the bug under Chrome. [...] Maybe a cache issue ?

Thanks, nice catch. I'm on Firefox>100. I'll try with Chromium to see if I can reproduce or not.

@Danger89 @effatee @cetcondor are you also using Firefox?

@effatee
Copy link

effatee commented Jun 7, 2022

@Danger89 @effatee @cetcondor are you also using Firefox?

Nope... Safari 15.4

@effatee
Copy link

effatee commented Jun 7, 2022

But... Just installed Firefox and Chrome to check.
Can't reproduce the issue on any of both after fresh install... login, main files page loads correctly...
Indeed might be a cache issue between v23 and v24...
Will clear cache on Safari and check.

@Ornanovitch
Copy link
Contributor Author

OK, so maybe this is somehow a reproducible bug only for a daily/normal use of NC with the same browser.

@effatee
Copy link

effatee commented Jun 7, 2022

I've just completely cleared cache/history and restarted Safari.
The issue was still there at first load... circling loading icon, no loading of files.
I then reloaded page... and files appeared.

Now each time I go to NC, files load normally. issue is gone...
Anyway... Clear cache... issue solved on my end with Safari 15.4

@Mer0me
Copy link

Mer0me commented Jun 7, 2022

We have had a similar issue with OnlyOffice file loading and that was a cache problem (an old js file was very persistent, and we had to delete it manually in firefox cache folder !). Maybe the way nextcloud deals with browser cache is problematic ?

@Ornanovitch
Copy link
Contributor Author

Ornanovitch commented Jun 7, 2022

OK thanks! I just cleared my browser's cache, I'll let you know if it works durably 🤞

If it does, I agree with @Mer0me that this is still a problematic behavior and that we should let this issue opened.

@melroy89
Copy link
Contributor

melroy89 commented Jun 7, 2022

We are all using Firefox 91.8.0 ESR [...] We cannot reproduce the bug under Chrome. [...] Maybe a cache issue ?

Thanks, nice catch. I'm on Firefox>100. I'll try with Chromium to see if I can reproduce or not.

@Danger89 @effatee @cetcondor are you also using Firefox?

Yes. Firefox 101.0

@Ornanovitch
Copy link
Contributor Author

OK thanks! I just cleared my browser's cache, I'll let you know if it works durably crossed_fingers

If it does, I agree with @Mer0me that this is still a problematic behavior and that we should let this issue opened.

No luck for me, the bug keeps happening :/

@Mer0me
Copy link

Mer0me commented Jun 15, 2022

Some news about this bug ? It's very annoying...

@Ornanovitch
Copy link
Contributor Author

No idea sorry

@MGousseff
Copy link

Still happening for me too.

@Mer0me
Copy link

Mer0me commented Jul 7, 2022

Can you reproduce error on v24.0.2 ? I've switched to this version this week and it seems to solve most of the problems.

@killerbees19
Copy link

Can you reproduce error on v24.0.2 ?

My personal experience: Not fixed in v24.0.2

@Ornanovitch
Copy link
Contributor Author

Ornanovitch commented Jul 7, 2022

Not fixed for me, at least when opening on a pinned tab on FF

2022-07-07-150509_786x727_scrot

@Mer0me
Copy link

Mer0me commented Jul 8, 2022

My bad, I could reproduce the bug today on 24.0.2. It's very annoying. Is there any plan to resolve it ?

@bassplayer404
Copy link

bassplayer404 commented Jul 8, 2022

I have the same problem with firefox and safari on different computers and with different users. No problems with chrome. NC 24.0.2. Clearing cache did not help.

@Mer0me
Copy link

Mer0me commented Jul 14, 2022

The files.js:173:6 seems to refer to /var/www/nextcloud/apps/text/js/text-files.js so I tried to disable "Text" app, and it seems to work. Could you test that on your instances ?

@Ornanovitch
Copy link
Contributor Author

Ornanovitch commented Jul 14, 2022

This is it, I confirm! Bug reappears as soon as I activate Text App again. Good catch :)

@Ornanovitch
Copy link
Contributor Author

@juliushaertl does it worth moving this issue to the Text App repo or should it remain here?

@Mer0me
Copy link

Mer0me commented Jul 14, 2022

It takes me some time to find out but I'm proud of me !
I think the issue should be in the Text App repo, or at least there should be a link to this post in the Text repo.

@juliushaertl
Copy link
Member

This is actually a regression caused by a timing issue where the response of the propound was hitting to early with https://github.com/nextcloud/text/pull/2193/files#diff-7b59ac385a5893f449345a411c1f98c8efc6735bab45bed8de4b354a12dc275cR172.

This got addressed by nextcloud/text#2677 and will be available with the next maintenance release.

@Ornanovitch
Copy link
Contributor Author

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

10 participants