-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sharing recommendations #14180
Show sharing recommendations #14180
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@blizzz please have a look. I think most of this code was originally from you 🙏 Note: there's a bit of duplication going on in the methods. They are very similar and yet slightly different. I don't know the code well enough to refactor it unfortunately, otherwise I would have tried to clean it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!!
Very nice work @ChristophWurst 👌
The design is off though, but I'm guessing this have nothing to do with this pr ? :)
Nope, I did not change any of the design here but just the behavior ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working nicely! :)
I guess the "Search globally" entry to appear on entry of search terms (to search the global user directory) is separate from this?
Nope, I did not change any of the design here but just the behavior ;)
Yep, this will happen in another PR! |
33235cb
to
4a2c3ac
Compare
Lots of |
@ChristophWurst restarted just in case https://drone.nextcloud.com/nextcloud/server/16123 |
And now other tests fail. What does this tell us? 🙈 |
This comment has been minimized.
This comment has been minimized.
c25a839
to
e596737
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
e596737
to
c484507
Compare
I only refactored it back in the day, apart of that I don't have much more insights to it than others :) |
Okay, no problem :) |
'name' => 'ShareesAPI#findRecommended', | ||
'url' => '/api/v1/sharees_recommended', | ||
'verb' => 'GET', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs:
Loading spinner appears on second render but does not hide anymorecan't reproduce anymore