-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search sharees on lookup server when explicitly requested by user #14333
Conversation
For the record here’s the mockup :) Btw @ChristophWurst, seems some unrelated files were edited maybe in the fixup?
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There seem to be a few UI hiccups here and there (already seen when working on #14180, hence this might be an old bug) but this generally works and also looks like @jancborchardt's mockup. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great! 👍
bbde099
to
ce55388
Compare
Thanks for testing! 🙌 I squashed my fixup commits and rebased onto master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4ee34cf
to
4533360
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Aaaaaaah now CI looks good :) Let me do a final squash&rebase |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
b9a5de0
to
e930a0c
Compare
Before
Sharee search either never or always goes to lookup server, depending on admin setting.
Now
Sharee search by default just searches locally. If no results are returned and the lookup server is not explicitly disabled by the admin, the user gets the option to search globally. This retriggers the search request but also includes lookup server results.
Note: I had some difficulties connection to the lookup server form my dev server but the default empty response for that is sufficient for testing :)
Todo