-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP: remove unused methods and DB values #22583
Conversation
/backport to stable19 |
/backport to stable18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
64341f1
to
18c6b98
Compare
This comment has been minimized.
This comment has been minimized.
- only references were in unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
18c6b98
to
bb02c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small naming suggestion, otherwise 👍
… prefs - also removes related app setting "updateAttributesInterval" Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
bb02c29
to
aa2d754
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🚀 🧹
We were still having the
update()
method on LDAP'sUser
class as well as related values we stored with the users. In the past we changed updating of user records to happen initially (on first importing), in the background, and on login. The use case to do it inline was not given anymore.update()
was now only referenced by unit tests. It made use of some other methods and also of thelastFeatureRequest
marker in the database. This is not needed anymore, and thus we do not need to write it anymore on every background run. The repair steps take care of removing these rows from the database.