Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] LDAP: remove unused methods and DB values #22631

Merged
merged 2 commits into from
Sep 10, 2020
Merged

[stable18] LDAP: remove unused methods and DB values #22631

merged 2 commits into from
Sep 10, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 6, 2020 •
edited by blizzz
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22583

@blizzz @backportbot
these code bits were part of old logic that was already refactored out
ea5b513 
- only references were in unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Sep 6, 2020
@blizzz
add repair step to clean up DB off lastFeatureRefresh entries in user…
24d464c 
… prefs

- also removes related app setting "updateAttributesInterval"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@faily-bot
Copy link

faily-bot bot commented Sep 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32744: failure

postgres9-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 10, 2020
@blizzz blizzz merged commit a3f4b6b into stable18 Sep 10, 2020
@blizzz blizzz deleted the backport/22583/stable18 branch September 10, 2020 08:01
@rullzer rullzer mentioned this pull request Sep 28, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap technical debt
Projects
None yet
Milestone
Nextcloud 18.0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@blizzz @juliushaertl