Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for advanced search API #41511

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Nov 15, 2023

  • / isn't allowed in UID, it will avoid conflicts
  • undeprecate getTerm on SearchQuery
  • introduce constants for builtin filters

`/` isn't allowed in UID, it will avoid conflicts

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim added the 3. to review Waiting for reviews label Nov 15, 2023
@Altahrim Altahrim added this to the Nextcloud 28 milestone Nov 15, 2023
@Altahrim Altahrim requested review from nickvergessen and a team November 15, 2023 15:59
@Altahrim Altahrim self-assigned this Nov 15, 2023
@Altahrim Altahrim requested review from ArtificialOwl, sorbaugh and come-nc and removed request for a team November 15, 2023 15:59
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but where is it generated like this? Need a second place that should use the constant?

@Altahrim
Copy link
Collaborator Author

but where is it generated like this?

That will be in frontend. For now it can be used with the API

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim changed the title Change person type separator Enhancements for advanced search API Nov 15, 2023
@blizzz blizzz mentioned this pull request Nov 16, 2023
@nickvergessen nickvergessen merged commit 7b45939 into master Nov 16, 2023
47 of 50 checks passed
@nickvergessen nickvergessen deleted the enh/advanced_search_backend branch November 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants