Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Use OCP constants for filters #10919

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix(search): Use OCP constants for filters #10919

merged 2 commits into from
Nov 17, 2023

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 16, 2023
@nickvergessen nickvergessen self-assigned this Nov 16, 2023
Altahrim
Altahrim approved these changes Nov 17, 2023
View reviewed changes
Copy link

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your usage, maybe methods like getTerm, getSince etc would be easier to use.
I imagine psalm errors are related to stubs

@nickvergessen
fix(search): Use OCP constants for filters
f3b801b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(deps): Bump nextcloud/OCP package
1ceb3ee 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/use-OCP-constants-for-filters branch from 3a6ec72 to 1ceb3ee Compare November 17, 2023 09:32
@nickvergessen
Copy link
Member Author

I imagine psalm errors are related to stubs

Yes, couldn't update the package yesterday, fixed now

For your usage, maybe methods like getTerm, getSince etc would be easier to use.

I don't see such methods in OCP, so getFilter() it is for now

@Altahrim
Copy link

I don't see such methods in OCP, so getFilter() it is for now

Not yet, just an idea I had in mind :)

@nickvergessen nickvergessen merged commit 6fdfabb into main Nov 17, 2023
47 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/use-OCP-constants-for-filters branch November 17, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: search 🔎 technical debt
Projects
None yet
Milestone
v18.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Altahrim