Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings section type attribute on settings app-content section #42590

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jan 5, 2024

To know if it's a user or admin section.

Follow-up to #35609 and also fixes #41513

Checklist

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
…ined before using them

Closes #41513

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just discovered the error on Sentry

👍 thanks

@nickvergessen
Copy link
Member

/backport to stable28

@nickvergessen nickvergessen merged commit 2c81525 into master Jan 10, 2024
49 of 50 checks passed
@nickvergessen nickvergessen deleted the add-settings-section-type-attribute branch January 10, 2024 08:23
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error message when entering a configuration menu
5 participants