Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings section type attribute on settings app-content section #42590

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Add settings section type attribute on settings app-content section #42590

merged 2 commits into from
Jan 10, 2024

Commits on Jan 5, 2024

  1. Add data-active-section-type attribute to app-content settings section 

    Signed-off-by: Thomas Citharel <tcit@tcit.fr>
    @tcitworld
    tcitworld committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c75fbf8 View commit details
    Browse the repository at this point in the history

  2. fix(settings): check if activeSectionId and activeSectionType are def… 

    …ined before using them

Closes #41513

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
    @tcitworld
    tcitworld committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    0d39079 View commit details
    Browse the repository at this point in the history