Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] prepare migration to lazy config #42820

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 15, 2024

With the changes on AppConfig in NC29 (#41755), this patch will only prep the database for a smoother migration to NC29's.

This patch will avoid error if trying to set/get app config values (also disable/enable apps) between the moment the file are updated and the upgrade is started.

@nickvergessen
Copy link
Member

Needs a version.php bump so the migration is triggered.
This is also missing in master.

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/prep-appconfig-migration-for-29 branch from f153563 to e501077 Compare January 18, 2024 01:16
@ArtificialOwl ArtificialOwl mentioned this pull request Jan 18, 2024
6 tasks
@ArtificialOwl
Copy link
Member Author

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/prep-appconfig-migration-for-29 branch from e501077 to 7b6b358 Compare January 22, 2024 12:33
@Altahrim Altahrim added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@Altahrim Altahrim mentioned this pull request Jan 22, 2024
@Altahrim Altahrim merged commit 2be4fb7 into stable28 Jan 22, 2024
49 of 52 checks passed
@Altahrim Altahrim deleted the enh/noid/prep-appconfig-migration-for-29 branch January 22, 2024 14:58
@nickvergessen
Copy link
Member

Block merges during freezes

🙈

@szaimen
Copy link
Contributor

szaimen commented Jul 23, 2024

Edit: nwvermind. This patch fixes the migration that was formerly not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants