-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve index on appconfig #42903
Merged
Merged
improve index on appconfig #42903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
enh/noid/improve-index-on-appconfig
branch
2 times, most recently
from
January 22, 2024 19:15
3cd94e9
to
bbe1bee
Compare
ArtificialOwl
changed the title
[wip] improve index on appconfig
improve index on appconfig
Jan 22, 2024
ArtificialOwl
requested review from
artonge,
a team,
icewind1991 and
Altahrim
and removed request for
a team
January 22, 2024 19:20
artonge
approved these changes
Jan 23, 2024
ArtificialOwl
force-pushed
the
enh/noid/improve-index-on-appconfig
branch
from
January 23, 2024 13:03
bbe1bee
to
d300919
Compare
ArtificialOwl
requested review from
nickvergessen
and removed request for
nickvergessen
January 23, 2024 13:12
ArtificialOwl
force-pushed
the
enh/noid/improve-index-on-appconfig
branch
2 times, most recently
from
January 23, 2024 16:35
6615418
to
5ad0674
Compare
nickvergessen
requested changes
Jan 23, 2024
ArtificialOwl
force-pushed
the
enh/noid/improve-index-on-appconfig
branch
from
January 24, 2024 20:05
5ad0674
to
3163277
Compare
I have estimated that a full squash+rebase was a lot better as I reverted a lot of code:
tested on
final result on each test:
|
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
enh/noid/improve-index-on-appconfig
branch
from
January 24, 2024 21:02
3163277
to
8362025
Compare
8 tasks
nickvergessen
approved these changes
Jan 25, 2024
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #42820
appconfig_configkey_key
index on single field configkey as there is no search on this fieldlazy
asTypes::INTEGER
(smallint(6)) instead ofTypes::BOOLEAN
to be able to set it aNotNull
(set in 28-rc2)lazy
$migrationCompleted
that was needed during the migration from 28 to 29 but not anymore since we generate the (previously) missing fieldslazy
andtype
in 28lazy
during loadConfig as we already know its valueNote: After some discussion, it seems better to switch
lazy
to INTEGER so the field can be set as NotNull (because Oracle)Fixes #43103