fix(federation): Allow cloud federation providers to handle unsuccess… #43884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ArtificialOwl,
ChristophWurst and
artonge
nickvergessen
commented
Feb 28, 2024
| * @throws \Throwable When $e did not have a response | ||
| * @since 29.0.0 | ||
| */ | ||
| public function getResponseFromThrowable(\Throwable $e): IResponse; |
There was a problem hiding this comment.
I added and used this method. I also put it in OCP, because it's not the first time where I find myself wanting to get the response of a "Guzzle ClientException" as an IResponse, without new \OC\…\Response() violating private class access.
…ful return codes Otherwise they are put to retry and will immediately trigger bruteforce protection infinitely Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/allow-to-handle-error-codes
branch
from
3e615d0
to
ecb111c
Compare
miaulalala
reviewed
Feb 28, 2024
| * @throws OCMProviderException | ||
| * @since 29.0.0 | ||
| */ | ||
| public function sendCloudShare(ICloudFederationShare $share): IResponse; |
There was a problem hiding this comment.
why add two new methods when you could modify the exisitng one?
There was a problem hiding this comment.
because it would now throw instead of returning false, which would break the current consumers?
miaulalala
approved these changes
Feb 28, 2024
SystemKeeper
approved these changes
Feb 28, 2024
ChristophWurst
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ful return codes
Otherwise they are put to retry and will immediately trigger bruteforce protection infinitely. This is currently easily producable when a federated user leaves a room during a "netsplit", maintenance mode or with a temporary error and afterwards people posting in the normal chat room.
Checklist