🌐 Federated invitation handling 💌 - API

[nickvergessen]

• Overview at 🌐 Federated invitation handling 💌 - Overview #11229

---

• FederationController->acceptShare() could return to user, who accepted a share, a local room (with token. e.t.c), so it could be reused by clients to join room on click => feat(federation): Add room to response when accepting an invite #11459
• Allow all users / only moderators / only specific groups on this server to invite users to Talk conversations from all other servers / only trusted servers - discuss? feat(federation): Add appconfig options to restrict federation #11503
• Return conversation name in getInvitation endpoint fix(federation)!: Add room name to invite and fix casing of properties #11505
• Prevent accepting the same invitation multiple times fix(federation): Fix accepting or declining an invite multiple times #11513
• Inviting the same user should not result in a new system message each time fix(federation): Fix accepting or declining an invite multiple times #11513
• Split subject and message for push notifications fix(federation): Fix accepting or declining an invite multiple times #11513
• The name (rich object) of the person which shared the conversation is missing on the invitation endpoint feat(federation): Add inviter information to the invitations DB for s… #11581

[nickvergessen]

• Boolean - Allow incoming
• Boolean - Allow outgoing
• Array - List of groups allowed to federate
• Boolean - Filter federation servers by trusted server list of server

[SystemKeeper]

spreed/lib/Model/Invitation.php

Lines 72 to 83 in 2bf22e1

	public function jsonSerialize(): array {
	return [
	'id' => $this->getId(),
	'user_id' => $this->getUserId(),
	'state' => $this->getState(),
	'local_room_id' => $this->getLocalRoomId(),
	'access_token' => $this->getAccessToken(),
	'remote_server_url' => $this->getRemoteServerUrl(),
	'remote_token' => $this->getRemoteToken(),
	'remote_attendee_id' => $this->getRemoteAttendeeId(),
	];
	}

The endpoint to get federation invitation does not include the conversation name that the user was invited to, but the notification does include that in the rich parameters:

I assume we should add that to the invitation endpoint as well?!

[SystemKeeper]

Same invitation can be accepted multiple times:

Inviting the same user does add a new system message each time (although no push notification):

[SystemKeeper]

Please split subject and message:

spreed/lib/Notification/Notifier.php

Lines 466 to 467 in 1ae1017

	$notification->setParsedSubject(str_replace($placeholders, $replacements, $message));
	$notification->setRichSubject($message, $rosParameters);

As we did for recording:

spreed/lib/Notification/Notifier.php

Lines 359 to 368 in 1ae1017

	if ($notification->getSubject() === 'record_file_stored') {
	$subject = $l->t('Call recording now available');
	$message = $l->t('The recording for the call in {call} was uploaded to {file}.');
	} elseif ($notification->getSubject() === 'transcript_file_stored') {
	$subject = $l->t('Transcript now available');
	$message = $l->t('The transcript for the call in {call} was uploaded to {file}.');
	} else {
	$subject = $l->t('Failed to transcript call recording');
	$message = $l->t('The server failed to transcript the recording at {file} for the call in {call}. Please reach out to the administration.');
	}

So push notifications can correctly show a subject and a message

[nickvergessen]

Please split subject and message

I think we should at least have the inviter in the subject

Suggestion:

{user1} invited you to a federated conversation

{user1} invited you to join {roomName} on {remoteServer}

[SystemKeeper]

Sounds good to me 👍

[nickvergessen]

• Added to fix(federation): Fix accepting or declining an invite multiple times #11513

[SystemKeeper]

The name of the person which shared the conversation is missing on the invitation endpoint, but it is available in the push notification. Can we add it to the endpoint as well?

[mahibi]

The name of the person which shared the conversation is missing on the invitation endpoint, but it is available in the push notification. Can we add it to the endpoint as well?

same for room name

[SystemKeeper]

same for room name

Should be fixed with #11505 already

[nickvergessen]

Inviting the same user should not result in a new system message each time

• -> Fixed in fix(federation): Fix accepting or declining an invite multiple times #11513

[nickvergessen]

Assuming all is done for now