Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer overlay doesn't support screensharing #9445

Closed
ShGKme opened this issue May 4, 2023 · 4 comments · Fixed by #10850
Closed

Viewer overlay doesn't support screensharing #9445

ShGKme opened this issue May 4, 2023 · 4 comments · Fixed by #10850

Comments

@ShGKme
Copy link
Contributor

ShGKme commented May 4, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Start a call with another active participant
  2. Start screen sharing from any:
    • another participant
    • youself
  3. Open a file in the viewer

Expected behaviour

There is a screen sharing in the viewer overlay

Actual behaviour

It is not

@Antreesy
Copy link
Contributor

Antreesy commented Aug 8, 2023

While doing that, now the confusing text is shown, waiting for X to join the call, while the participant is still there, just a peer from his screensharing is not passed to the overlay

@nickvergessen
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Ref #9445

Steps to reproduce

  1. Be 2 people in the call
  2. User A shares a document
  3. User A shares their screen
  4. User B opens the document

Expected behaviour

Mini preview shows the screenshare or other person

Actual behaviour

Mini preview shows "Waiting for X to join the call"
image

Talk app

Talk app version: 17.0.3

@nickvergessen
Copy link
Member

@DorraJaouad was this touched/solved by your work?

@DorraJaouad
Copy link
Contributor

No, the ViewerOverlayCallView is a different component from CallView component . It is lacking Screen components for both local model and the promoted model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants