Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ViewerOverlayCallView): Add screensharing support #10850

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat(ViewerOverlayCallView): Add screensharing support #10850

merged 2 commits into from
Nov 29, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 8, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

TODO

  • Add the remote peer screen ( promoted peer)
  • Promotion is following the promotion order in CallView

🏁 Checklist

@DorraJaouad
feat(ViewerOverlayCallView): add the local screen
bd53dae 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Nov 8, 2023
@DorraJaouad
feat(ViewerOverlayCallView): Add remote screenshare support
6b618a4 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad self-assigned this Nov 16, 2023
@DorraJaouad DorraJaouad marked this pull request as ready for review November 16, 2023 12:01
@Antreesy
Copy link
Contributor

cc @ShGKme as overlay component author

@Antreesy Antreesy requested a review from ShGKme November 16, 2023 13:22
@ShGKme
Copy link
Contributor

ShGKme commented Nov 16, 2023

🥲

image

@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023 •
edited
Loading

I guess, 2. Developing can be changed to 3. To review and ready to merge? Seems to work fine on my testing, and looks complete according to the code.

@nickvergessen
Copy link
Member

/backport to stable28

@DorraJaouad DorraJaouad merged commit c006f0e into main Nov 29, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/9445/overlay-screenshare branch November 29, 2023 10:58
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2023
Merged
@Antreesy Antreesy mentioned this pull request Dec 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@DorraJaouad DorraJaouad

Labels
2. developing 3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Viewer overlay doesn't support screensharing
4 participants
@DorraJaouad @Antreesy @ShGKme @nickvergessen