Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Allow sessions to mark themselves as inactive #10544

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix(notifications): Allow sessions to mark themselves as inactive #10544

merged 2 commits into from
Sep 26, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 20, 2023 •
edited by Antreesy
Loading

☑️ Resolves

🏁 Checklist

@nickvergessen nickvergessen added 3. to review enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 20, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Sep 20, 2023
@nickvergessen nickvergessen self-assigned this Sep 20, 2023
@nickvergessen
fix(notifications): Allow sessions to mark themselves as inactive
2e7b140 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/1575/notification-with-inactive-tabs branch from deb93b2 to 2e7b140 Compare September 21, 2023 07:58
@Antreesy Antreesy self-assigned this Sep 25, 2023
@Antreesy
fix(App) send server request from inactive tab
d833dd3 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the bugfix/1575/notification-with-inactive-tabs branch from d10e09e to d833dd3 Compare September 26, 2023 08:49
nickvergessen
nickvergessen commented Sep 26, 2023
View reviewed changes
Copy link
Member Author

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend code seems to work 👍🏼

Antreesy
Antreesy approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend also works fine

@nickvergessen nickvergessen merged commit 7dadcc0 into master Sep 26, 2023
48 checks passed
@nickvergessen nickvergessen deleted the bugfix/1575/notification-with-inactive-tabs branch September 26, 2023 10:58
@Antreesy Antreesy mentioned this pull request Oct 15, 2023
Merged
2 tasks
@SystemKeeper SystemKeeper mentioned this pull request Feb 10, 2024
Closed
@Antreesy Antreesy mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@nickvergessen nickvergessen

@Antreesy Antreesy

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Notifications for chats are not showing when browser tab/window is inactive
3 participants
@nickvergessen @SystemKeeper @Antreesy