Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useActiveSession): adjust behavior of inactive session #10714

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 15, 2023

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

…toast showing

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/10544/adjust-inactive-session branch from 06a028f to 331d498 Compare October 19, 2023 08:43
@Antreesy Antreesy marked this pull request as ready for review October 19, 2023 08:43
@nickvergessen nickvergessen merged commit 30c4fea into master Oct 23, 2023
35 of 36 checks passed
@nickvergessen nickvergessen deleted the fix/10544/adjust-inactive-session branch October 23, 2023 05:14
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 13, 2023

No visual changes

lie 😛

Bildschirmfoto vom 2023-11-13 15-56-11

should this show in production?

Context: I use two screens. If I use Talk on one and my IDE on the other I get to see the toast every now and then. It's a bit distracting.

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 13, 2023

lie 😛

It hasn't been added with this PR, just some cases for showing it were removed (was even worse before 🙈)

should this show in production?

As Joas said today, we'll keep it until final release, to be able to catch issues on beta. Yes, it's distracting 😬

@nickvergessen
Copy link
Member

nickvergessen commented Nov 13, 2023

Context: I use two screens. If I use Talk on one and my IDE on the other I get to see the toast every now and then. It's a bit distracting.

It already helped finding a bug where it was toggled while being in a call sharing the own screen 😅👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants