Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(API): Remove unused variables and deprecated methods #11069

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(API): Remove unused variables and deprecated methods #11069

merged 1 commit into from
Dec 4, 2023

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants labels Dec 1, 2023
@nickvergessen nickvergessen self-assigned this Dec 1, 2023
@nickvergessen
fix(API): Remove unused variables and deprecated methods
ca14e7a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
SystemKeeper
SystemKeeper approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works:
image

SystemKeeper
SystemKeeper approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works:
image

@nickvergessen nickvergessen merged commit 023bd07 into main Dec 4, 2023
48 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/update-bfp-handling branch December 4, 2023 09:13
@nickvergessen
Copy link
Member Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @SystemKeeper